You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Vianney Carel (JIRA)" <ji...@apache.org> on 2010/08/05 10:15:16 UTC
[jira] Commented: (HTTPCLIENT-974) RequestWrapper does not use the
headers of the request it wraps.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895610#action_12895610 ]
Vianney Carel commented on HTTPCLIENT-974:
------------------------------------------
Actually, I'm using it to manually handle redirects on HTTP 302, and reposting data in some cases.
This class wouldn't be there, I would have had to do something similar... :-)
> RequestWrapper does not use the headers of the request it wraps.
> ----------------------------------------------------------------
>
> Key: HTTPCLIENT-974
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-974
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0.1
> Reporter: Vianney Carel
> Priority: Trivial
> Fix For: 4.1 Alpha3
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The RequestWrapper does not use the headers of the request it wraps. Therefore the wrapper appears as having no header, while the wrapped request may have some.
> To work-around that behavior, I have to call resetHeaders() on the wrapper just after having created it.
> This method does the following:
> public void resetHeaders()
> {
> headergroup.clear();
> setHeaders(original.getAllHeaders());
> }
> I suggest calling setHeaders directly in the constructor. Or at least highlight in the Javadoc that we should call resetHeaders().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org