You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/08/09 13:28:05 UTC
[GitHub] [camel-kamelets] claudio4j opened a new issue, #1562: Update apiVersion in kamelets to v1
claudio4j opened a new issue, #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] apupier commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1673264189
Starting to work on this issue (I cannot assign it me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] claudio4j commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1673417984
Related to the rename in the `camel-kamelets/templates/bindings/camel-k/`, afaik there are no external refernces to them, they are self contained examples for reference. There is no harm renaming their names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] apupier commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1672756251
Trying to gather what needs to be modified for the move from kameletBinding to Pipe:
- doc
- function name https://github.com/apache/camel-kamelets/blob/5c44e19587fd96c3736163d526c155af9218f39f/docs/modules/ROOT/examples/js/kamelets.js#L164
- folder name https://github.com/apache/camel-kamelets/tree/5c44e19587fd96c3736163d526c155af9218f39f/templates/bindings
- kind in binding files, fo rinstance https://github.com/apache/camel-kamelets/blob/5c44e19587fd96c3736163d526c155af9218f39f/templates/bindings/camel-k/ftp-sink-binding.yaml#L2 whcih will need to change the api version too I guess
- name of binding file, for instance https://github.com/apache/camel-kamelets/blob/5c44e19587fd96c3736163d526c155af9218f39f/templates/bindings/camel-k/ftp-sink-binding.yaml#L2
- Yaks test case https://github.com/apache/camel-kamelets/blob/5c44e19587fd96c3736163d526c155af9218f39f/test/data-type-action/data-type-action.feature#L16 (is Yaks already changed the name?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] davsclaus commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1730174803
Has all this been done, and if so this can be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] claudio4j commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1673412694
Your proposal sounds good, I think everything is taken care of.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] apupier commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1671334010
I guess KameletsCatalog must be updated too https://github.com/apache/camel-kamelets/blob/2501406adba5b8751c4caa23793aa428ac1df451/library/camel-kamelets-catalog/src/main/java/org/apache/camel/kamelets/catalog/KameletsCatalog.java#L43-L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd closed issue #1562: Update apiVersion in kamelets to v1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd closed issue #1562: Update apiVersion in kamelets to v1
URL: https://github.com/apache/camel-kamelets/issues/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on issue #1562: Update apiVersion in kamelets to v1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on issue #1562:
URL: https://github.com/apache/camel-kamelets/issues/1562#issuecomment-1730182740
Not yet we need a release of 4.1.0 or 4.0.1 to complete this issue. There is a PR open waiting for the release. I think it is for yaks test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org