You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by amethystic <gi...@git.apache.org> on 2016/10/20 09:08:23 UTC
[GitHub] kafka pull request #2045: Fix for kafka-4295: kafka-console-consumer.sh does...
GitHub user amethystic opened a pull request:
https://github.com/apache/kafka/pull/2045
Fix for kafka-4295: kafka-console-consumer.sh does not delete the temporary group in zookeeper
Since consumer stop logic and zk node removal code are in separate threads, so when two threads execute in an interleaving manner, persistent node '/consumers/<consumer-group>' might not be removed for those console consumer groups which do not specify "group.id". This will pollute Zookeeper with lots of inactive console consumer offset information.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amethystic/kafka kafka-4295-consoleconsumer_failed_remove_zknodes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2045
----
commit 95779d7d509c012e9e3d1931fc3b6fd465075513
Author: huxi <hu...@zhenrongbao.com>
Date: 2016-10-20T09:03:31Z
Fix for kafka-4295: kafka-console-consumer.sh does not delete the temporary group in zookeeper
Since consumer stop logic and zk node removal code are in separate threads, so when two threads execute in an interleaving manner, persistent node '/consumers/<consumer-group>' might not be removed for those console consumer groups which do not specify "group.id". This will pollute Zookeeper with lots of inactive console consumer offset information.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2045: Fix for kafka-4295: kafka-console-consumer.sh does...
Posted by amethystic <gi...@git.apache.org>.
Github user amethystic closed the pull request at:
https://github.com/apache/kafka/pull/2045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2045: Fix for kafka-4295: kafka-console-consumer.sh does...
Posted by amethystic <gi...@git.apache.org>.
Github user amethystic closed the pull request at:
https://github.com/apache/kafka/pull/2045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2045: Fix for kafka-4295: kafka-console-consumer.sh does...
Posted by amethystic <gi...@git.apache.org>.
GitHub user amethystic reopened a pull request:
https://github.com/apache/kafka/pull/2045
Fix for kafka-4295: kafka-console-consumer.sh does not delete the temporary group in zookeeper
Since consumer stop logic and zk node removal code are in separate threads, so when two threads execute in an interleaving manner, persistent node '/consumers/<consumer-group>' might not be removed for those console consumer groups which do not specify "group.id". This will pollute Zookeeper with lots of inactive console consumer offset information.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amethystic/kafka kafka-4295-consoleconsumer_failed_remove_zknodes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2045
----
commit 95779d7d509c012e9e3d1931fc3b6fd465075513
Author: huxi <hu...@zhenrongbao.com>
Date: 2016-10-20T09:03:31Z
Fix for kafka-4295: kafka-console-consumer.sh does not delete the temporary group in zookeeper
Since consumer stop logic and zk node removal code are in separate threads, so when two threads execute in an interleaving manner, persistent node '/consumers/<consumer-group>' might not be removed for those console consumer groups which do not specify "group.id". This will pollute Zookeeper with lots of inactive console consumer offset information.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---