You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/07/26 07:12:34 UTC
[GitHub] [airflow] eladkal opened a new pull request, #32854: Set openlineage provider as ready to be released
eladkal opened a new pull request, #32854:
URL: https://github.com/apache/airflow/pull/32854
We are ready to prepare the provider wave before cutting 2.7.0 thus this is the time to add openlineage to release cycle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #32854: Set openlineage provider as ready to be released
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #32854:
URL: https://github.com/apache/airflow/pull/32854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #32854: Set openlineage provider as ready to be released
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #32854:
URL: https://github.com/apache/airflow/pull/32854#discussion_r1274544726
##########
dev/provider_packages/prepare_provider_packages.py:
##########
@@ -1676,10 +1676,12 @@ def verify_changelog_exists(package: str) -> str:
def list_providers_packages():
"""List all provider packages."""
providers = get_all_providers()
- # For now we should exclude open-lineage from being consider for releasing until it is ready to
- # be released
- if "openlineage" in providers:
- providers.remove("openlineage")
+ # if provider needs to be not considered in release add it here
+ # this is useful for cases where provider is WIP for a long period thus we don't want to release it yet.
+ providers_to_remove_from_release = []
+ for provider in providers_to_remove_from_release:
+ if provider in providers:
+ providers.remove(provider)
for provider in providers:
console.print(provider)
Review Comment:
Why do the in-place modification? We can just stick a `if provider in providers_to_remove_from_release: continue` in the latter for loop instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #32854: Set openlineage provider as ready to be released
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #32854:
URL: https://github.com/apache/airflow/pull/32854#discussion_r1274600131
##########
dev/provider_packages/prepare_provider_packages.py:
##########
@@ -1676,10 +1676,12 @@ def verify_changelog_exists(package: str) -> str:
def list_providers_packages():
"""List all provider packages."""
providers = get_all_providers()
- # For now we should exclude open-lineage from being consider for releasing until it is ready to
- # be released
- if "openlineage" in providers:
- providers.remove("openlineage")
+ # if provider needs to be not considered in release add it here
+ # this is useful for cases where provider is WIP for a long period thus we don't want to release it yet.
+ providers_to_remove_from_release = []
+ for provider in providers_to_remove_from_release:
+ if provider in providers:
+ providers.remove(provider)
for provider in providers:
console.print(provider)
Review Comment:
It's not the same list.
We have list of all providers and we have providers to exclude. I just converted the providers to exclude into a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #32854: Set openlineage provider as ready to be released
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #32854:
URL: https://github.com/apache/airflow/pull/32854#discussion_r1274669785
##########
dev/provider_packages/prepare_provider_packages.py:
##########
@@ -1676,10 +1676,12 @@ def verify_changelog_exists(package: str) -> str:
def list_providers_packages():
"""List all provider packages."""
providers = get_all_providers()
- # For now we should exclude open-lineage from being consider for releasing until it is ready to
- # be released
- if "openlineage" in providers:
- providers.remove("openlineage")
+ # if provider needs to be not considered in release add it here
+ # this is useful for cases where provider is WIP for a long period thus we don't want to release it yet.
+ providers_to_remove_from_release = []
+ for provider in providers_to_remove_from_release:
+ if provider in providers:
+ providers.remove(provider)
for provider in providers:
console.print(provider)
Review Comment:
My question was why you need to modify the list at all. I was suggesting
```python
for provider in providers:
if provider in providers_to_remove_from_release:
continue
console.print(provider)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org