You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/12/12 01:47:53 UTC
Review Request 64521: Made `StatusUpdateManagerProcess` fill-in the
latest status update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64521/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
Made `StatusUpdateManagerProcess` fill-in the latest status update.
Diffs
-----
src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
src/tests/offer_operation_status_update_manager_tests.cpp a5327d3d070a390f2ceb918dc53a024fbfe8777e
Diff: https://reviews.apache.org/r/64521/diff/1/
Testing
-------
Added a new test, which passes on GNU/Linux. The other existing tests also pass.
Thanks,
Gaston Kleiman
Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in
the latest status update.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64521/#review193747
-----------------------------------------------------------
src/status_update_manager/status_update_manager_process.hpp
Lines 168-172 (patched)
<https://reviews.apache.org/r/64521/#comment272383>
Could you submit a follow-up patch to update the comments in the offer operation SUM to explain this constraint?
src/tests/offer_operation_status_update_manager_tests.cpp
Lines 843 (patched)
<https://reviews.apache.org/r/64521/#comment272387>
s/latest status update/latest status/
I'll fix this while committing.
- Greg Mann
On Dec. 13, 2017, 12:25 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64521/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 12:25 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `StatusUpdateManagerProcess` fill in the latest status update.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
> src/tests/offer_operation_status_update_manager_tests.cpp a5327d3d070a390f2ceb918dc53a024fbfe8777e
>
>
> Diff: https://reviews.apache.org/r/64521/diff/3/
>
>
> Testing
> -------
>
> Added a new test, which passes on GNU/Linux. The other existing tests also pass.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in
the latest status update.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64521/
-----------------------------------------------------------
(Updated Dec. 12, 2017, 4:25 p.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Changes
-------
Addressed feedback.
Summary (updated)
-----------------
Made `StatusUpdateManagerProcess` fill in the latest status update.
Repository: mesos
Description (updated)
-------
Made `StatusUpdateManagerProcess` fill in the latest status update.
Diffs (updated)
-----
src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
src/tests/offer_operation_status_update_manager_tests.cpp a5327d3d070a390f2ceb918dc53a024fbfe8777e
Diff: https://reviews.apache.org/r/64521/diff/3/
Changes: https://reviews.apache.org/r/64521/diff/2-3/
Testing
-------
Added a new test, which passes on GNU/Linux. The other existing tests also pass.
Thanks,
Gaston Kleiman
Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in
the latest status update.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On Dec. 12, 2017, 1:21 p.m., Greg Mann wrote:
> > src/status_update_manager/status_update_manager_process.hpp
> > Lines 513 (patched)
> > <https://reviews.apache.org/r/64521/diff/1/?file=1912886#file1912886line515>
> >
> > AFAICT there's nothing preventing somebody from setting `latest_status` on an update they pass into this process, causing us to fail this check?
Added a validation in the SUM's `update` method.
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64521/#review193598
-----------------------------------------------------------
On Dec. 12, 2017, 4:25 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64521/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 4:25 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `StatusUpdateManagerProcess` fill in the latest status update.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
> src/tests/offer_operation_status_update_manager_tests.cpp a5327d3d070a390f2ceb918dc53a024fbfe8777e
>
>
> Diff: https://reviews.apache.org/r/64521/diff/3/
>
>
> Testing
> -------
>
> Added a new test, which passes on GNU/Linux. The other existing tests also pass.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill-in
the latest status update.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64521/#review193598
-----------------------------------------------------------
src/status_update_manager/status_update_manager_process.hpp
Lines 513-514 (original), 511-514 (patched)
<https://reviews.apache.org/r/64521/#comment272168>
Let's add a `CHECK_NOTNULL(stream);` here as well.
src/status_update_manager/status_update_manager_process.hpp
Lines 513 (patched)
<https://reviews.apache.org/r/64521/#comment272164>
AFAICT there's nothing preventing somebody from setting `latest_status` on an update they pass into this process, causing us to fail this check?
src/tests/offer_operation_status_update_manager_tests.cpp
Lines 906-916 (patched)
<https://reviews.apache.org/r/64521/#comment272173>
Since we test this functionality elsewhere, we can remove this block.
- Greg Mann
On Dec. 12, 2017, 1:47 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64521/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 1:47 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `StatusUpdateManagerProcess` fill-in the latest status update.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
> src/tests/offer_operation_status_update_manager_tests.cpp a5327d3d070a390f2ceb918dc53a024fbfe8777e
>
>
> Diff: https://reviews.apache.org/r/64521/diff/2/
>
>
> Testing
> -------
>
> Added a new test, which passes on GNU/Linux. The other existing tests also pass.
>
>
> Thanks,
>
> Gaston Kleiman
>
>