You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/08/02 02:05:51 UTC

[GitHub] spark pull request #21892: [SPARK-24945][SQL] Switching to uniVocity 2.7.2

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21892#discussion_r207083344
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala ---
    @@ -203,19 +203,11 @@ class UnivocityParser(
         }
       }
     
    -  private val doParse = if (requiredSchema.nonEmpty) {
    --- End diff --
    
    This change looks good to me though, we need this in this pr? This fix should be addressed in #21909?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org