You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by elbarto132 <gi...@git.apache.org> on 2014/04/07 15:22:31 UTC
[GitHub] cordova-plugin-geolocation pull request: Update CDVLocation.m
GitHub user elbarto132 opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/16
Update CDVLocation.m
Changed distanceFilter from none to 5 meters, prevents it from spamming the callback even though nothing changed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elbarto132/cordova-plugin-geolocation patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 67317751f76799e54a77e78a9cc06a5033accedf
Author: elbarto132 <jo...@gmail.com>
Date: 2014-04-07T13:22:12Z
Update CDVLocation.m
Changed distanceFilter from none to 5 meters, prevents it from spamming the callback even though nothing changed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-geolocation pull request: Update CDVLocation.m
Posted by kalebdf <gi...@git.apache.org>.
Github user kalebdf commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/16#issuecomment-45982891
This is a pretty crucial "fix". It could be configurable long term.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-geolocation pull request: Update CDVLocation.m
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/16#issuecomment-46069135
@elbarto132 ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-geolocation pull request: Update CDVLocation.m
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/16#issuecomment-41095961
Thank you for the PR. Can't tell from your profile whether you have signed the Apache iCLA: https://www.apache.org/licenses/icla.txt
This needs to be signed and emailed before Apache can accept your contrib.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-geolocation pull request: Update CDVLocation.m
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---