You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/11 14:04:04 UTC
[GitHub] [maven-integration-testing] MartinKanters opened a new pull request #137: Set Maven compiler and release versions to 7 for integration test projects
MartinKanters opened a new pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137
See discussion here: https://github.com/apache/maven-integration-testing/pull/135#discussion_r787104645.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137#issuecomment-1036351678
@mthmulders Nice find! Fixed that as well.
@michael-o Checked > 8, but there are no occurrences as far as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters merged pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
MartinKanters merged pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137#discussion_r804817388
##########
File path: core-it-suite/src/test/resources/mng-7045/pom.xml
##########
@@ -25,8 +25,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
- <source>8</source>
- <target>8</target>
+ <source>7</source>
Review comment:
Likely depends on the Java version used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] mthmulders commented on a change in pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137#discussion_r804809670
##########
File path: core-it-suite/src/test/resources/mng-7045/pom.xml
##########
@@ -25,8 +25,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
- <source>8</source>
- <target>8</target>
+ <source>7</source>
Review comment:
Is that valid? I thought dropping the `1.` is allowed only from 8 onwards, but I'm not sure...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137#issuecomment-1036320449
Check with >8 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137#discussion_r805191451
##########
File path: core-it-suite/src/test/resources/mng-7045/pom.xml
##########
@@ -25,8 +25,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
- <source>8</source>
- <target>8</target>
+ <source>7</source>
Review comment:
Good point, I was a bit too hasty there. For my JDK (OpenJDK) it worked with "7", but made it "1.7" just to be sure. It works with that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137#discussion_r805191451
##########
File path: core-it-suite/src/test/resources/mng-7045/pom.xml
##########
@@ -25,8 +25,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
- <source>8</source>
- <target>8</target>
+ <source>7</source>
Review comment:
Good point, I was a bit too hasty there. For my JDK (OpenJDK) it worked with "7", but made it "1.7" just to be sure. It works with that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters merged pull request #137: Set Maven compiler and release versions to 7 for integration test projects
Posted by GitBox <gi...@apache.org>.
MartinKanters merged pull request #137:
URL: https://github.com/apache/maven-integration-testing/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org