You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:52:31 UTC
[GitHub] [kafka] dajac opened a new pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
dajac opened a new pull request #11264:
URL: https://github.com/apache/kafka/pull/11264
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906960791
Merged to trunk, 3.0 and 2.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906665382
New run to validate: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4665/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906709897
Successful run: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-branch-builder--1630007187--dajac--KAFKA-13231--7007d8ec3/report.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906316909
> Transactions system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4663/
All tests have passed: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-branch-builder--1629974240--dajac--KAFKA-13231--584309932/report.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#discussion_r696813850
##########
File path: tests/kafkatest/services/transactional_message_copier.py
##########
@@ -159,12 +159,16 @@ def pids(self, node):
def alive(self, node):
return len(self.pids(node)) > 0
+ def start_node(self, node):
+ BackgroundThreadService.start_node(self, node)
+ wait_until(lambda: self.alive(node), timeout_sec=60, err_msg="Message Copier failed to start")
Review comment:
Is it worth adding `node` to these error messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #11264:
URL: https://github.com/apache/kafka/pull/11264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906262222
Transactions system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4663/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906664923
@hachikuji updated the PR to add the node to the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org