You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/28 15:53:36 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #5935: [AIRFLOW-5330] Add project_id to Datastore hook and operators

mik-laj commented on a change in pull request #5935: [AIRFLOW-5330] Add project_id to Datastore hook and operators
URL: https://github.com/apache/airflow/pull/5935#discussion_r318660539
 
 

 ##########
 File path: tests/gcp/hooks/datastore.py
 ##########
 @@ -50,12 +52,12 @@ def test_allocate_ids(self, mock_get_conn):
         self.datastore_hook.connection = mock_get_conn.return_value
         partial_keys = []
 
-        keys = self.datastore_hook.allocate_ids(partial_keys)
+        keys = self.datastore_hook.allocate_ids(partial_keys=partial_keys, project_id=GCP_PROJECT_ID)
 
 Review comment:
   Can you also add tests when project ID is missing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services