[jira] [Commented] (FLINK-3650) Add maxBy/minBy to Scala DataSet API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267009#comment-15267009 ] 

ASF GitHub Bot commented on FLINK-3650:
---------------------------------------

Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1856#discussion_r61769474
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java ---
    @@ -72,8 +73,8 @@ public T reduce(T value1, T value2) throws Exception {
     		for (int position : fields) {
     			// Save position of compared key
     			// Get both values - both implement comparable
    -			Comparable comparable1 = value1.getFieldNotNull(position);
    -			Comparable comparable2 = value2.getFieldNotNull(position);
    +			Comparable comparable1 = ((Tuple)value1).getFieldNotNull(position);
    --- End diff --
    
    I have a doubt here. Previously also this SelectByMaxFunction was extending T extends Tuple. So TupleTypeInfo was actually allowed here. So even now we are allowing TypeInformation<T> which is the super class of TupleTypeInfo. So it should work the same way as it was earlier?


> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
>                 Key: FLINK-3650
>                 URL: https://issues.apache.org/jira/browse/FLINK-3650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. These methods are not supported by the Scala DataSet API. These methods should be added in order to have a consistent API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)