You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2018/05/18 18:43:27 UTC
Review Request 67219: [IGNORE] testing flaky webhook test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
[IGNORE] testing flaky webhook test
Diffs
-----
build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
Diff: https://reviews.apache.org/r/67219/diff/1/
Testing
-------
Thanks,
Jordan Ly
Re: Review Request 67219: [IGNORE] testing flaky webhook test
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203461
-----------------------------------------------------------
Ship it!
Master (805a53f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 18, 2018, 6:43 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 6:43 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> [IGNORE] testing flaky webhook test
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: [IGNORE] testing flaky webhook test
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203458
-----------------------------------------------------------
@ReviewBot retry
- Jordan Ly
On May 18, 2018, 6:43 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 6:43 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> [IGNORE] testing flaky webhook test
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: [IGNORE] testing flaky webhook test
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203445
-----------------------------------------------------------
Master (805a53f) is red with this patch.
./build-support/jenkins/build.sh
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:248)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:241)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:230)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:123)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:79)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:104)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:98)
at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:625)
at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:580)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:98)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
Caused by: org.gradle.api.GradleException: There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
at org.gradle.api.tasks.testing.Test.handleTestFailures(Test.java:1447)
at org.gradle.api.tasks.testing.Test.executeTests(Test.java:721)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:142)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:135)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:122)
at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:762)
at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:729)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:121)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:110)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:92)
... 28 more
* Get more help at https://help.gradle.org
BUILD FAILED in 7m 13s
45 actionable tasks: 36 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 18, 2018, 6:43 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 6:43 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> [IGNORE] testing flaky webhook test
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh a5975398929d01268841fa4c02aa360b309f6114
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: [IGNORE] testing flaky webhook test
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203457
-----------------------------------------------------------
Ship it!
Master (805a53f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 18, 2018, 6:43 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 6:43 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> [IGNORE] testing flaky webhook test
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: Fix flaky Webhook test by ensuring proper
error condition
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203508
-----------------------------------------------------------
Ship it!
Ship It!
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
Line 244 (original), 241 (patched)
<https://reviews.apache.org/r/67219/#comment285801>
Update comment.
- Santhosh Kumar Shanmugham
On May 21, 2018, 11 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 11 a.m.)
>
>
> Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Attempt #3 at fixing the flaky Webhook test once and for all.
>
> Previously, I was testing the error condition by hitting a bad url with a port of -1. I believe this was erroneous (I am assuming the -1 overflowed into a valid port). Additionally, there was a timing associated with the test which could make it flaky as well.
>
> I ensured that the test hit a bad host url and removed the timing for a more deterministic test.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/4/
>
>
> Testing
> -------
>
> `./gradlew test` passes.
>
> Repeated AuroraBot tests.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: Fix flaky Webhook test by ensuring proper
error condition
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203512
-----------------------------------------------------------
Ship it!
Master (805a53f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 21, 2018, 6:28 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 6:28 p.m.)
>
>
> Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Attempt #3 at fixing the flaky Webhook test once and for all.
>
> Previously, I was testing the error condition by hitting a bad url with a port of -1. I believe this was erroneous (I am assuming the -1 overflowed into a valid port). Additionally, there was a timing associated with the test which could make it flaky as well.
>
> I ensured that the test hit a bad host url and removed the timing for a more deterministic test.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/5/
>
>
> Testing
> -------
>
> `./gradlew test` passes.
>
> Repeated AuroraBot tests.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: Fix flaky Webhook test by ensuring proper
error condition
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/#review203520
-----------------------------------------------------------
Ship it!
Ship It!
- Renan DelValle
On May 21, 2018, 11:28 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67219/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 11:28 a.m.)
>
>
> Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Attempt #3 at fixing the flaky Webhook test once and for all.
>
> Previously, I was testing the error condition by hitting a bad url with a port of -1. I believe this was erroneous (I am assuming the -1 overflowed into a valid port). Additionally, there was a timing associated with the test which could make it flaky as well.
>
> I ensured that the test hit a bad host url and removed the timing for a more deterministic test.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
>
>
> Diff: https://reviews.apache.org/r/67219/diff/5/
>
>
> Testing
> -------
>
> `./gradlew test` passes.
>
> Repeated AuroraBot tests.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67219: Fix flaky Webhook test by ensuring proper
error condition
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/
-----------------------------------------------------------
(Updated May 21, 2018, 6:28 p.m.)
Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
Changes
-------
Updated comment.
Repository: aurora
Description
-------
Attempt #3 at fixing the flaky Webhook test once and for all.
Previously, I was testing the error condition by hitting a bad url with a port of -1. I believe this was erroneous (I am assuming the -1 overflowed into a valid port). Additionally, there was a timing associated with the test which could make it flaky as well.
I ensured that the test hit a bad host url and removed the timing for a more deterministic test.
Diffs (updated)
-----
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
Diff: https://reviews.apache.org/r/67219/diff/5/
Changes: https://reviews.apache.org/r/67219/diff/4-5/
Testing
-------
`./gradlew test` passes.
Repeated AuroraBot tests.
Thanks,
Jordan Ly
Re: Review Request 67219: Fix flaky Webhook test by ensuring proper
error condition
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67219/
-----------------------------------------------------------
(Updated May 21, 2018, 6 p.m.)
Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
Changes
-------
Namings.
Summary (updated)
-----------------
Fix flaky Webhook test by ensuring proper error condition
Repository: aurora
Description (updated)
-------
Attempt #3 at fixing the flaky Webhook test once and for all.
Previously, I was testing the error condition by hitting a bad url with a port of -1. I believe this was erroneous (I am assuming the -1 overflowed into a valid port). Additionally, there was a timing associated with the test which could make it flaky as well.
I ensured that the test hit a bad host url and removed the timing for a more deterministic test.
Diffs (updated)
-----
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b
Diff: https://reviews.apache.org/r/67219/diff/4/
Changes: https://reviews.apache.org/r/67219/diff/3-4/
Testing (updated)
-------
`./gradlew test` passes.
Repeated AuroraBot tests.
Thanks,
Jordan Ly