You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2019/10/10 20:44:44 UTC
[incubator-pinot] branch master updated: Remove "refresh" usecase
check in RoutingTableBuilderFactory (#4687)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b824b48 Remove "refresh" usecase check in RoutingTableBuilderFactory (#4687)
b824b48 is described below
commit b824b480f1110a16d5157f6a8cbd96cf860a6bf8
Author: Seunghyun Lee <sn...@linkedin.com>
AuthorDate: Thu Oct 10 13:44:39 2019 -0700
Remove "refresh" usecase check in RoutingTableBuilderFactory (#4687)
We have created "DefaultOfflineRoutingTableBuilder" when the
use case is a refresh use case. Since PartitionAwareOffline
should work with the refresh table, we are removing the check.
---
.../apache/pinot/broker/routing/RoutingTableBuilderFactory.java | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingTableBuilderFactory.java b/pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingTableBuilderFactory.java
index a9b897f..1624597 100644
--- a/pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingTableBuilderFactory.java
+++ b/pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingTableBuilderFactory.java
@@ -117,13 +117,7 @@ public class RoutingTableBuilderFactory {
// Check that replica group strategy config is correctly set
boolean hasReplicaGroupStrategyConfig = (validationConfig.getReplicaGroupStrategyConfig() != null);
-
- // Check that the table push type is not 'refresh'.
- boolean isNotRefreshPush =
- (validationConfig.getSegmentPushType() != null) && !validationConfig.getSegmentPushType()
- .equalsIgnoreCase("REFRESH");
-
- if (isSegmentAssignmentStrategyCorrect && hasReplicaGroupStrategyConfig && isNotRefreshPush) {
+ if (isSegmentAssignmentStrategyCorrect && hasReplicaGroupStrategyConfig) {
builder = new PartitionAwareOfflineRoutingTableBuilder();
} else {
builder = new DefaultOfflineRoutingTableBuilder();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org