You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/05 12:31:03 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31489: [WIP][SQL] Support parquet datasource options to control datetime rebasing in read
MaxGekk opened a new pull request #31489:
URL: https://github.com/apache/spark/pull/31489
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
By running the modified test suites:
```
$ build/sbt "sql/test:testOnly *ParquetRebaseDatetimeV1Suite"
$ build/sbt "sql/test:testOnly *ParquetRebaseDatetimeV2Suite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774420334
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774029491
**[Test build #134934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134934/testReport)** for PR 31489 at commit [`f898288`](https://github.com/apache/spark/commit/f898288f495406b98c3a72e0afb462099bbcc65b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774195173
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134934/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31489:
URL: https://github.com/apache/spark/pull/31489
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774180092
**[Test build #134934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134934/testReport)** for PR 31489 at commit [`f898288`](https://github.com/apache/spark/commit/f898288f495406b98c3a72e0afb462099bbcc65b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774195173
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134934/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-775150366
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [WIP][SQL] Support parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774029491
**[Test build #134934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134934/testReport)** for PR 31489 at commit [`f898288`](https://github.com/apache/spark/commit/f898288f495406b98c3a72e0afb462099bbcc65b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774647555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39569/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774267949
**[Test build #134940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134940/testReport)** for PR 31489 at commit [`eb77fc6`](https://github.com/apache/spark/commit/eb77fc6581a1aeb67a3c84d1252e16f8dc9b43b6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774465668
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134951/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31489:
URL: https://github.com/apache/spark/pull/31489#discussion_r572042517
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
##########
@@ -52,14 +52,16 @@ import org.apache.spark.util.SerializableConfiguration
* @param readDataSchema Required schema of Parquet files.
* @param partitionSchema Schema of partitions.
* @param filters Filters to be pushed down in the batch scan.
+ * @param parquetOptions The options of Parquet datasource that are set for the read.
*/
case class ParquetPartitionReaderFactory(
sqlConf: SQLConf,
broadcastedConf: Broadcast[SerializableConfiguration],
dataSchema: StructType,
readDataSchema: StructType,
partitionSchema: StructType,
- filters: Array[Filter]) extends FilePartitionReaderFactory with Logging {
+ filters: Array[Filter],
+ parquetOptions: ParquetOptions) extends FilePartitionReaderFactory with Logging {
Review comment:
ah nvm, we read the confs and put it in `val`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774430144
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774632676
**[Test build #134986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134986/testReport)** for PR 31489 at commit [`ebc7298`](https://github.com/apache/spark/commit/ebc7298bde1b6bb5c7eab05b731bea6d67127ff0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31489:
URL: https://github.com/apache/spark/pull/31489#discussion_r572042040
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
##########
@@ -52,14 +52,16 @@ import org.apache.spark.util.SerializableConfiguration
* @param readDataSchema Required schema of Parquet files.
* @param partitionSchema Schema of partitions.
* @param filters Filters to be pushed down in the batch scan.
+ * @param parquetOptions The options of Parquet datasource that are set for the read.
*/
case class ParquetPartitionReaderFactory(
sqlConf: SQLConf,
broadcastedConf: Broadcast[SerializableConfiguration],
dataSchema: StructType,
readDataSchema: StructType,
partitionSchema: StructType,
- filters: Array[Filter]) extends FilePartitionReaderFactory with Logging {
+ filters: Array[Filter],
+ parquetOptions: ParquetOptions) extends FilePartitionReaderFactory with Logging {
Review comment:
Does it really work? The 2 fields of `ParquetOptions` are `transient`, and become null after (de)serialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774667272
**[Test build #134986 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134986/testReport)** for PR 31489 at commit [`ebc7298`](https://github.com/apache/spark/commit/ebc7298bde1b6bb5c7eab05b731bea6d67127ff0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774415968
**[Test build #134951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134951/testReport)** for PR 31489 at commit [`f33b5a8`](https://github.com/apache/spark/commit/f33b5a85d56ee99f98df11a2f3cac4f1f568a836).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774314202
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39523/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31489:
URL: https://github.com/apache/spark/pull/31489#discussion_r571539866
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -825,6 +825,26 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging {
* must be in the following form: YYYY-MM-DDTHH:mm:ss (e.g. 2020-06-01T13:00:00)</li>
* <li>`recursiveFileLookup`: recursively scan a directory for files. Using this option
* disables partition discovery</li>
+ * <li>`datetimeRebaseMode`: the rebasing mode for the values of the `DATE`, `TIMESTAMP_MICROS`,
+ * `TIMESTAMP_MILLIS` logical types from the Julian to Proleptic Gregorian calendar:
+ * <ul>
+ * <li>`EXCEPTION` : Spark fails in reads of ancient dates/timestamps that are ambiguous
+ * between the two calendars</li>
+ * <li>`CORRECTED` : loading of dates/timestamps without rebasing</li>
+ * <li>`LEGACY` : perform rebasing of ancient dates/timestamps from the Julian to Proleptic
+ * Gregorian calendar</li>
+ * </ul>
+ * </li>
+ * <li>`int96RebaseMode`: the rebasing mode for `INT96` timestamps from the Julian to Proleptic
+ * Gregorian calendar:
Review comment:
Shall we mention that the default is the one set in `spark.sql.legacy.parquet.datetimeRebaseModeInRead`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774672363
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134986/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31489: [WIP][SQL] Support parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31489:
URL: https://github.com/apache/spark/pull/31489#discussion_r570936150
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRebaseDatetimeSuite.scala
##########
@@ -273,12 +292,12 @@ abstract class ParquetRebaseDatetimeSuite
withAllParquetReaders {
// The file metadata indicates if it needs rebase or not, so we can always get the
// correct result regardless of the "rebase mode" config.
- Seq(LEGACY, CORRECTED, EXCEPTION).foreach { mode =>
- withSQLConf(SQLConf.LEGACY_AVRO_REBASE_MODE_IN_READ.key -> mode.toString) {
Review comment:
Fixed the wrong SQL conf: LEGACY_**AVRO**_REBASE_MODE_IN_READ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31489: [SPARK-34377][SQL] Support parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774086913
@cloud-fan @tomvanbussel @mswit-databricks Could you review this PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774430144
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774415968
**[Test build #134951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134951/testReport)** for PR 31489 at commit [`f33b5a8`](https://github.com/apache/spark/commit/f33b5a85d56ee99f98df11a2f3cac4f1f568a836).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774458348
**[Test build #134951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134951/testReport)** for PR 31489 at commit [`f33b5a8`](https://github.com/apache/spark/commit/f33b5a85d56ee99f98df11a2f3cac4f1f568a836).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774465668
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134951/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774647555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39569/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774353695
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134940/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774314202
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39523/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774353695
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134940/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31489: [SPARK-34377][SQL] Support parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774088540
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39517/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774672363
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134986/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774302930
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39523/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774639685
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39569/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774632676
**[Test build #134986 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134986/testReport)** for PR 31489 at commit [`ebc7298`](https://github.com/apache/spark/commit/ebc7298bde1b6bb5c7eab05b731bea6d67127ff0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774288380
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39523/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774641973
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39569/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774423907
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31489: [SPARK-34377][SQL] Support parquet datasource options to control datetime rebasing in read
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31489:
URL: https://github.com/apache/spark/pull/31489#issuecomment-774088540
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39517/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org