You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/10/06 21:42:08 UTC

mesos git commit: Fixed invalid comment formatting in the docker RegistryClient.

Repository: mesos
Updated Branches:
  refs/heads/master 7d2720063 -> 4bc8eeedd


Fixed invalid comment formatting in the docker RegistryClient.

Review: https://reviews.apache.org/r/39013


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/4bc8eeed
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/4bc8eeed
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/4bc8eeed

Branch: refs/heads/master
Commit: 4bc8eeedd6b5ee39b9c0932b0f78a117a5445a31
Parents: 7d27200
Author: Jojy Varghese <jo...@mesosphere.io>
Authored: Tue Oct 6 12:37:26 2015 -0700
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Tue Oct 6 12:38:15 2015 -0700

----------------------------------------------------------------------
 src/slave/containerizer/provisioner/docker/registry_client.cpp | 3 +--
 src/slave/containerizer/provisioner/docker/registry_client.hpp | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/4bc8eeed/src/slave/containerizer/provisioner/docker/registry_client.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/provisioner/docker/registry_client.cpp b/src/slave/containerizer/provisioner/docker/registry_client.cpp
index c2040b4..4931ae8 100644
--- a/src/slave/containerizer/provisioner/docker/registry_client.cpp
+++ b/src/slave/containerizer/provisioner/docker/registry_client.cpp
@@ -433,7 +433,6 @@ Future<ManifestResponse> RegistryClientProcess::getManifest(
     const Option<string>& tag,
     const Duration& timeout)
 {
-  //TODO(jojy): These validations belong in the URL class.
   if (strings::contains(path, " ")) {
     return Failure("Invalid repository path: " + path);
   }
@@ -518,7 +517,7 @@ Future<size_t> RegistryClientProcess::getBlob(
   auto prepare = ([&filePath]() -> Try<Nothing> {
       const string dirName = filePath.dirname();
 
-      //TODO(jojy): Return more state, for example - if the directory is new.
+      // TODO(jojy): Return more state, for example - if the directory is new.
       Try<Nothing> dirResult = os::mkdir(dirName, true);
       if (dirResult.isError()) {
         return Error(

http://git-wip-us.apache.org/repos/asf/mesos/blob/4bc8eeed/src/slave/containerizer/provisioner/docker/registry_client.hpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/provisioner/docker/registry_client.hpp b/src/slave/containerizer/provisioner/docker/registry_client.hpp
index 9d5d154..fdb68b6 100644
--- a/src/slave/containerizer/provisioner/docker/registry_client.hpp
+++ b/src/slave/containerizer/provisioner/docker/registry_client.hpp
@@ -48,8 +48,8 @@ public:
    * Encapsulates information about a file system layer.
    */
   struct FileSystemLayerInfo {
-    //TODO(jojy): This string includes the checksum type also now. Need to
-    //separate this into checksum method and checksum.
+    // TODO(jojy): This string includes the checksum type also now. Need to
+    // separate this into checksum method and checksum.
     std::string checksumInfo;
   };