You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Brian Vargas (JIRA)" <xa...@xml.apache.org> on 2005/06/30 16:18:22 UTC

[jira] Created: (XALANJ-2163) Incorrect error message in booleanF method.

Incorrect error message in booleanF method.
-------------------------------------------

         Key: XALANJ-2163
         URL: http://issues.apache.org/jira/browse/XALANJ-2163
     Project: XalanJ2
        Type: Bug
  Components: XSLTC  
    Versions: CurrentCVS    
 Environment: All.
    Reporter: Brian Vargas
    Priority: Trivial


The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".

It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)

In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.

The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Closed: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2163?page=all ]
     
Brian Minchau closed XALANJ-2163:
---------------------------------


closing this issue.

> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: Latest Development Code
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>      Fix For: 2.7
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Updated: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2163?page=all ]

Brian Minchau updated XALANJ-2163:
----------------------------------

      Xalan info: [PatchAvailable]
    fix-priority: fp4

> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: CurrentCVS
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Updated: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2163?page=all ]

Brian Minchau updated XALANJ-2163:
----------------------------------

    Attachment: BasisLibrary.2163.patch.txt

Patch produced by Brian Minchau, but is really based on the comments already in this issue.


> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: CurrentCVS
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Updated: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2163?page=all ]

Brian Minchau updated XALANJ-2163:
----------------------------------

    Fix Version: 2.7

> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: CurrentCVS
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>      Fix For: 2.7
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Commented: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Vargas (JIRA)" <xa...@xml.apache.org>.
    [ http://issues.apache.org/jira/browse/XALANJ-2163?page=comments#action_12330503 ] 

Brian Vargas commented on XALANJ-2163:
--------------------------------------

I can confirm that this has been fixed on the 2.7.0 release.


> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: Latest Development Code
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>      Fix For: 2.7
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Commented: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
    [ http://issues.apache.org/jira/browse/XALANJ-2163?page=comments#action_12319261 ] 

Brian Minchau commented on XALANJ-2163:
---------------------------------------

Brian Vargas,
the trivial change was made and is now in the 2.7 release. Would you confirm that the problem is fixed, then we can close this issue.

> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: Latest Development Code
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>      Fix For: 2.7
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Resolved: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2163?page=all ]
     
Brian Minchau resolved XALANJ-2163:
-----------------------------------

    Resolution: Fixed

Patch reviewed by Brian Minchau, it is OK.

Patch commited to CVS.

> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: CurrentCVS
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Assigned: (XALANJ-2163) Incorrect error message in booleanF method.

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2163?page=all ]

Brian Minchau reassigned XALANJ-2163:
-------------------------------------

    Assign To: Brian Minchau

> Incorrect error message in booleanF method.
> -------------------------------------------
>
>          Key: XALANJ-2163
>          URL: http://issues.apache.org/jira/browse/XALANJ-2163
>      Project: XalanJ2
>         Type: Bug
>   Components: XSLTC
>     Versions: CurrentCVS
>  Environment: All.
>     Reporter: Brian Vargas
>     Assignee: Brian Minchau
>     Priority: Trivial
>  Attachments: BasisLibrary.2163.patch.txt
>
> The implementation of the XSLTC XPath boolean() function in the BasisLibrary.booleanF() method contains an incorrect error message that appears when the method receives an inappropriate argument.  The else clause passes "number()" to the runtimeError() method, when it should pass the string "boolean()".
> It looks to me like somebody got a bit too overzealous in their copy-paste coding.  ;-)
> In any event, it makes for a killer red herring in the rare event that that error occurs, and the fix is trivial.
> The file is src/org/apache/xalan/xsltc/runtime/BasisLibrary.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org