GMSJoinLeaveJUnitTest format is broken?

[Kirk Lund <kl...@apache.org>]

* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.
> Format violations were found. Run 'gradlew spotlessApply' to fix them.

../../geode/geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output.

BUILD FAILED

Re: GMSJoinLeaveJUnitTest format is broken?

[Dan Smith <ds...@pivotal.io>]

Sent that too soon!

I think everyone should always run ./gradlew build before pushing changes
to avoid breaking the build. I'm not sure what the solution is for
spotless, but we should be checking things before pushing them. One thing
to consider is adding a pre-push hook to force a build to run whenever you
try to push something:

incubator-geode> echo "./gradlew build" > .git/hooks/pre-push

-Dan

On Mon, Nov 14, 2016 at 10:36 AM, Dan Smith <ds...@pivotal.io> wrote:

> Everyone should always run ./gradlew
>
> On Mon, Nov 14, 2016 at 10:35 AM, Bruce Schuchardt <bschuchardt@pivotal.io
> > wrote:
>
>> This is fixed now.  I will not apologize for breaking the build though.
>> I formatted the code that I checked in with the provided formatter
>> configuration for Idea and that should pass the spotlessCheck task.
>>
>> We should turn off spotlessCheck until the IDE formatters conform to the
>> spotlessCheck rules.
>>
>>
>> Le 11/14/2016 à 10:27 AM, Kirk Lund a écrit :
>>
>>> * What went wrong:
>>> Execution failed for task ':geode-core:spotlessJavaCheck'.
>>>
>>>> Format violations were found. Run 'gradlew spotlessApply' to fix them.
>>>>
>>> ../../geode/geode-core/src/test/java/org/apache/geode/distri
>>> buted/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>>>
>>> * Try:
>>> Run with --stacktrace option to get the stack trace. Run with --info or
>>> --debug option to get more log output.
>>>
>>> BUILD FAILED
>>>
>>>
>>
>

Re: GMSJoinLeaveJUnitTest format is broken?

[Dan Smith <ds...@pivotal.io>]

Everyone should always run ./gradlew

On Mon, Nov 14, 2016 at 10:35 AM, Bruce Schuchardt <bs...@pivotal.io>
wrote:

> This is fixed now.  I will not apologize for breaking the build though.  I
> formatted the code that I checked in with the provided formatter
> configuration for Idea and that should pass the spotlessCheck task.
>
> We should turn off spotlessCheck until the IDE formatters conform to the
> spotlessCheck rules.
>
>
> Le 11/14/2016 à 10:27 AM, Kirk Lund a écrit :
>
>> * What went wrong:
>> Execution failed for task ':geode-core:spotlessJavaCheck'.
>>
>>> Format violations were found. Run 'gradlew spotlessApply' to fix them.
>>>
>> ../../geode/geode-core/src/test/java/org/apache/geode/distri
>> buted/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>>
>> * Try:
>> Run with --stacktrace option to get the stack trace. Run with --info or
>> --debug option to get more log output.
>>
>> BUILD FAILED
>>
>>
>

Re: GMSJoinLeaveJUnitTest format is broken?

[Bruce Schuchardt <bs...@pivotal.io>]

This is fixed now.  I will not apologize for breaking the build though.  
I formatted the code that I checked in with the provided formatter 
configuration for Idea and that should pass the spotlessCheck task.

We should turn off spotlessCheck until the IDE formatters conform to the 
spotlessCheck rules.

Le 11/14/2016 � 10:27 AM, Kirk Lund a �crit :
> * What went wrong:
> Execution failed for task ':geode-core:spotlessJavaCheck'.
>> Format violations were found. Run 'gradlew spotlessApply' to fix them.
> ../../geode/geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
>
> BUILD FAILED
>