[GitHub] [apisix] bisakhmondal commented on a change in pull request #6498: docs: fix python script bug

[GitBox <gi...@apache.org>]

bisakhmondal commented on a change in pull request #6498:
URL: https://github.com/apache/apisix/pull/6498#discussion_r820236133



##########
File path: docs/en/latest/mtls.md
##########
@@ -103,7 +103,7 @@ import sys
 # sudo pip install requests
 import requests
 
-if len(sys.argv) <= 4:
+if len(sys.argv) < 4:

Review comment:
       It's okay, I think the script is being adapted to be used in storing server certs and keys in APISIX as well, along with mTLS client ca information. It's a minor change and if it ends up helping people, I think it's okay to be merged : )

##########
File path: docs/en/latest/mtls.md
##########
@@ -166,7 +166,7 @@ import sys
 # sudo pip install requests
 import requests
 
-if len(sys.argv) <= 4:
+if len(sys.argv) < 4:

Review comment:
       nice catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org