You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Myroslav Papirkovskyy <mp...@hortonworks.com> on 2018/01/05 17:44:58 UTC
Review Request 64983: Setup heartbeat for api endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64983/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle.
Bugs: AMBARI-22738
https://issues.apache.org/jira/browse/AMBARI-22738
Repository: ambari
Description
-------
API endpoint uses sockJS fallback options. The SockJS protocol requires server to set proper heartbeat configuration.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4dffcaa23ab6a7ca5e2f558ae2bbc3ba89d4cbc4
ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java e968b11f1ae22631cc656003b98ce1da83b25cee
Diff: https://reviews.apache.org/r/64983/diff/1/
Testing
-------
manual testing
Thanks,
Myroslav Papirkovskyy
Re: Review Request 64983: Setup heartbeat for api endpoint.
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64983/#review194879
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Jan. 5, 2018, 5:44 p.m., Myroslav Papirkovskyy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64983/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 5:44 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle.
>
>
> Bugs: AMBARI-22738
> https://issues.apache.org/jira/browse/AMBARI-22738
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API endpoint uses sockJS fallback options. The SockJS protocol requires server to set proper heartbeat configuration.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4dffcaa23ab6a7ca5e2f558ae2bbc3ba89d4cbc4
> ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java e968b11f1ae22631cc656003b98ce1da83b25cee
>
>
> Diff: https://reviews.apache.org/r/64983/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Myroslav Papirkovskyy
>
>
Re: Review Request 64983: Setup heartbeat for api endpoint.
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64983/#review194880
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On Jan. 5, 2018, 5:44 p.m., Myroslav Papirkovskyy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64983/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 5:44 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy, and Sid Wagle.
>
>
> Bugs: AMBARI-22738
> https://issues.apache.org/jira/browse/AMBARI-22738
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API endpoint uses sockJS fallback options. The SockJS protocol requires server to set proper heartbeat configuration.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 4dffcaa23ab6a7ca5e2f558ae2bbc3ba89d4cbc4
> ambari-server/src/main/java/org/apache/ambari/server/configuration/spring/ApiStompConfig.java e968b11f1ae22631cc656003b98ce1da83b25cee
>
>
> Diff: https://reviews.apache.org/r/64983/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Myroslav Papirkovskyy
>
>