[jira] [Comment Edited] (IMAGING-84) Generate tests.jar so client projects can leverage test image data easily

["Farrukh Najmi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMAGING-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403077#comment-13403077 ] 

Farrukh Najmi edited comment on IMAGING-84 at 6/28/12 1:27 PM:
---------------------------------------------------------------

Using test data is not always the only reason to have a tests.jar artifact from a project. Another reason is when a project extends another project then it may want to also the base project's test classes as part of its own test suite. Do you see a downside to the project producing a tests.jar artifact?

Also, please see my comment on IMAGING-85 on why I think it is not unusual to load test data from the classpath in junit tests.

Feel free to close the issue if you and other dev team members are still -1 on this.

                
      was (Author: farrukhnajmi):
    Using test data is not always the only reason to have a tests.jar artifact from a project. Another reason is when a project extends another project then it may want to also the base project's test classes as part of its own test suite. Do you see a downside to the project producing a tests.jar artifact?

Also, please see my comment on IMAGING-83 on why I think it is not unusual to load test data from the classpath in junit tests.

                  
> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: IMAGING-84
>                 URL: https://issues.apache.org/jira/browse/IMAGING-84
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set. 
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira