You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/07/15 16:09:43 UTC
[GitHub] flink pull request: [docs] Document some missing configuration par...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/915
[docs] Document some missing configuration parameters
The change is also adding some code for finding undocumented config constants in the setup/config.md file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink these_small_issues_you_know
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #915
----
commit e9ac3a9b54857683fefcc89bf74d06cdfda000bd
Author: Robert Metzger <rm...@apache.org>
Date: 2015-07-15T14:08:43Z
[docs] Document some missing configuration parameters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Document some missing configuration par...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Document some missing configuration par...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/915#discussion_r34682821
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -730,4 +737,25 @@
* Not instantiable.
*/
private ConfigConstants() {}
+
--- End diff --
I think this should go into a util class, possibly in `test` scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Document some missing configuration par...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/915#issuecomment-123363590
Will clean this up and merge it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---