You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/11/23 21:31:26 UTC

[GitHub] rabbah closed pull request #4128: Delete unnecessary code comments

rabbah closed pull request #4128: Delete unnecessary code comments
URL: https://github.com/apache/incubator-openwhisk/pull/4128
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala b/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
index 15dbf2ec62..c3ed36c0e6 100644
--- a/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
+++ b/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
@@ -469,22 +469,6 @@ object ShardingContainerPoolBalancer extends LoadBalancerProvider {
     logging: Logging,
     materializer: ActorMaterializer): LoadBalancer = {
 
-//    private val activeAckTopic = s"completed${controllerInstance.asString}"
-//    private val maxActiveAcksPerPoll = 128
-//    private val activeAckPollDuration = 1.second
-//    private val activeAckConsumer =
-//    messagingProvider.getConsumer(config, activeAckTopic, activeAckTopic, maxPeek = maxActiveAcksPerPoll)
-//
-//    private val activationFeed = actorSystem.actorOf(Props {
-//      new MessageFeed(
-//        "activeack",
-//        logging,
-//        activeAckConsumer,
-//        maxActiveAcksPerPoll,
-//        activeAckPollDuration,
-//        processAcknowledgement)
-//    })
-
     val activeAckTopic = s"completed${instance.asString}"
     val maxActiveAcksPerPoll = 128
     val activeAckPollDuration = 1.second


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services