DO NOT REPLY [Bug 17779] New: - null should mean "all records" and NOT "all known records"

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17779>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17779

null should mean "all records" and NOT "all known records"

           Summary: null should mean "all records" and NOT "all known
                    records"
           Product: POI
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: HSSF
        AssignedTo: poi-dev@jakarta.apache.org
        ReportedBy: ncsaba@yahoo.com


The HSSF event model is filtering out any unknown records unless the listener is
explicitly registered to receive all record sids it wants to pass through... the
null parameter for record sids to be processed will default to the list of known
records.

In my opinion this is not the best behavior, as there's no way to specify "pass
through all records, even if unknown". The current behavior ("pass through all
known records") can be achieved easily by passing
EventRecordFactory.getAllKnownRecordSIDs() when registering the filter.

My proposal is just pass through all records if the list of sids is null.

I'm aware that this might brake some existing applications which rely on the
current behavior, causing them to potentially receive unknown records, but they
are easily fixed by passing EventRecordFactory.getAllKnownRecordSIDs() instead
of null.
(Not to mention that some of the applications will suddenly work better by
keeping images and the like :)