You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/01/17 08:37:22 UTC
[GitHub] [druid] isandeep41 opened a new pull request #12162: enable github workflow to automate helm chart test
isandeep41 opened a new pull request #12162:
URL: https://github.com/apache/druid/pull/12162
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Fixes #11997
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
Enable helm chart test for druid using github action
* Create initial helm-release action for druid
* Add lint-test job
* Run job for master only
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #12162: enable github workflow to automate helm chart test
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #12162:
URL: https://github.com/apache/druid/pull/12162#discussion_r786222032
##########
File path: helm/druid/Chart.yaml
##########
@@ -17,6 +17,10 @@ apiVersion: v2
appVersion: 0.22.0
description: Apache Druid is a high performance real-time analytics database.
name: druid
+maintainers:
Review comment:
There is no particular maintainers in apache projects because those projects are maintained by communities which anyone can join if they want. We should not add such a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on a change in pull request #12162: enable github workflow to automate helm chart test
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on a change in pull request #12162:
URL: https://github.com/apache/druid/pull/12162#discussion_r786547157
##########
File path: helm/druid/Chart.yaml
##########
@@ -17,6 +17,10 @@ apiVersion: v2
appVersion: 0.22.0
description: Apache Druid is a high performance real-time analytics database.
name: druid
+maintainers:
Review comment:
thanks, I have removed the list and added a flag to skip the maintainers validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on a change in pull request #12162: enable github workflow to automate helm chart test
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on a change in pull request #12162:
URL: https://github.com/apache/druid/pull/12162#discussion_r786129205
##########
File path: helm/druid/Chart.yaml
##########
@@ -17,6 +17,10 @@ apiVersion: v2
appVersion: 0.22.0
description: Apache Druid is a high performance real-time analytics database.
name: druid
+maintainers:
Review comment:
I have updated the helm chart maintainers list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #12162: enable github workflow to automate helm chart test
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #12162:
URL: https://github.com/apache/druid/pull/12162#discussion_r785808236
##########
File path: helm/druid/Chart.yaml
##########
@@ -17,6 +17,10 @@ apiVersion: v2
appVersion: 0.22.0
description: Apache Druid is a high performance real-time analytics database.
name: druid
+maintainers:
Review comment:
Since @maver1ck @AWaterColorPen and I are the [authors](https://github.com/helm/charts/commit/ebe628b5adb8c5410e844a12650fb829dcfdd594#diff-a29b6218f791902feb80876c36a479a9f1b1211b06e4c99b770e7f67fa53f66c) of this Apache Druid Helm Chart, it is better to add the three of us too. So if there are any questions to discuss in the future, it is also easy to find us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #12162: enable github workflow to automate helm chart test
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #12162:
URL: https://github.com/apache/druid/pull/12162#discussion_r786421774
##########
File path: helm/druid/Chart.yaml
##########
@@ -17,6 +17,10 @@ apiVersion: v2
appVersion: 0.22.0
description: Apache Druid is a high performance real-time analytics database.
name: druid
+maintainers:
Review comment:
@jihoonson Sure, please @isandeep41 help to remove the list, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 closed pull request #12162: enable github workflow to automate helm chart test
Posted by GitBox <gi...@apache.org>.
isandeep41 closed pull request #12162:
URL: https://github.com/apache/druid/pull/12162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org