You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/21 17:03:31 UTC

[GitHub] [tvm] tqchen opened a new pull request, #13651: [RPC] Add fail-guard for termination time exception

tqchen opened a new pull request, #13651:
URL: https://github.com/apache/tvm/pull/13651

   This PR adds fail-guard to reduce error messages thrown during process termination time. Such error won't trigger test error but will bring extra message during exit time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #13651: [RPC] Add fail-guard for termination time exception

Posted by GitBox <gi...@apache.org>.
tqchen commented on PR #13651:
URL: https://github.com/apache/tvm/pull/13651#issuecomment-1362907412

   Example snippet
   
   ```
   Exception ignored in: <function Server.__del__ at 0x7fb012d9add0>
   Traceback (most recent call last):
     File "/home/tqchen/github/relax/python/tvm/rpc/server.py", line 502, in __del__
     File "/home/tqchen/github/relax/python/tvm/rpc/server.py", line 498, in terminate
     File "/home/tqchen/github/relax/python/tvm/contrib/popen_pool.py", line 145, in kill
     File "/home/tqchen/github/relax/python/tvm/contrib/popen_pool.py", line 43, in kill_child_processes
   ImportError: sys.meta_path is None, Python is likely shutting down
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] echuraev commented on pull request #13651: [RPC] Add fail-guard for termination time exception

Posted by GitBox <gi...@apache.org>.
echuraev commented on PR #13651:
URL: https://github.com/apache/tvm/pull/13651#issuecomment-1363290564

   Thank you for the clarification!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #13651: [RPC] Add fail-guard for termination time exception

Posted by GitBox <gi...@apache.org>.
tqchen commented on PR #13651:
URL: https://github.com/apache/tvm/pull/13651#issuecomment-1362829420

   This would be some rare case that have to do with shutdown orders likely in multi processing. I have observed some flaky ones during purest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] echuraev merged pull request #13651: [RPC] Add fail-guard for termination time exception

Posted by GitBox <gi...@apache.org>.
echuraev merged PR #13651:
URL: https://github.com/apache/tvm/pull/13651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13651: [RPC] Add fail-guard for termination time exception

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13651:
URL: https://github.com/apache/tvm/pull/13651#issuecomment-1361676466

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `rpc` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org