You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by br...@apache.org on 2012/10/05 10:10:25 UTC
svn commit: r1394404 - in /continuum/trunk:
continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/
continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/
Author: brett
Date: Fri Oct 5 08:10:24 2012
New Revision: 1394404
URL: http://svn.apache.org/viewvc?rev=1394404&view=rev
Log:
[CONTINUUM-2688] '.' should be allowed in goals to specify a group ID
Modified:
continuum/trunk/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/BuildDefinitionTest.java
continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml
Modified: continuum/trunk/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/BuildDefinitionTest.java
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/BuildDefinitionTest.java?rev=1394404&r1=1394403&r2=1394404&view=diff
==============================================================================
--- continuum/trunk/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/BuildDefinitionTest.java (original)
+++ continuum/trunk/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/BuildDefinitionTest.java Fri Oct 5 08:10:24 2012
@@ -210,6 +210,15 @@ public class BuildDefinitionTest
buildDefinitionDescription, false, false, false );
}
+ public void testAddNotDefaultProjectBuildDefinitionWithLongMavenGoal()
+ throws Exception
+ {
+ goToProjectInformationPage( projectGroupName, projectName );
+ clickLinkWithXPath( "//input[contains(@id,'buildDefinition')]" );
+ addEditGroupBuildDefinition( null, buildDefinitionPomName, "clean org.apache.maven.plugins:maven-compile-plugin:2.4:compile", buildDefinitionArguments,
+ buildDefinitionDescription, false, false, false );
+ }
+
@Test( dependsOnMethods = { "testAddNotDefaultProjectBuildDefinition" } )
public void testDeleteProjectBuildDefinition()
throws Exception
Modified: continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml?rev=1394404&r1=1394403&r2=1394404&view=diff
==============================================================================
--- continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml (original)
+++ continuum/trunk/continuum-webapp/src/main/resources/org/apache/maven/continuum/web/action/BuildDefinitionAction-saveBuildDefinition-validation.xml Fri Oct 5 08:10:24 2012
@@ -35,7 +35,7 @@
<field name="goals">
<field-validator type="regex">
<param name="trim">true</param>
- <param name="expression"><![CDATA[[A-Za-z0-9_:\s\-]*]]></param>
+ <param name="expression"><![CDATA[[A-Za-z0-9_:\s.\-]*]]></param>
<message key="buildDefinition.goals.invalid"/>
</field-validator>
</field>