You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/09 19:46:05 UTC
[GitHub] [beam] damccorm opened a new pull request, #24625: interface{} -> any for remaining references
damccorm opened a new pull request, #24625:
URL: https://github.com/apache/beam/pull/24625
Should be the last one for `sdks/go`. There might be others in the repo (in boot.go's or playground/TOB), but I'm not going to dig for those.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24625:
URL: https://github.com/apache/beam/pull/24625#issuecomment-1344728160
Did a quick check and boot.go files don't have any instances of interface{} so its a non-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #24625:
URL: https://github.com/apache/beam/pull/24625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24625:
URL: https://github.com/apache/beam/pull/24625#discussion_r1044796709
##########
sdks/go/test/integration/io/xlang/bigquery/bigquery_test.go:
##########
@@ -18,14 +18,15 @@ package bigquery
import (
"flag"
"fmt"
- "github.com/apache/beam/sdks/v2/go/pkg/beam/register"
"log"
"math/rand"
"reflect"
"strings"
"testing"
"time"
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/register"
Review Comment:
I think this is a consequence of running `go fmt` on the test directory (previously I ran it on `pkg/beam` only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24625:
URL: https://github.com/apache/beam/pull/24625#issuecomment-1344722625
R: @lostluck
Last one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #24625:
URL: https://github.com/apache/beam/pull/24625#discussion_r1044800102
##########
sdks/go/test/integration/io/xlang/bigquery/bigquery_test.go:
##########
@@ -18,14 +18,15 @@ package bigquery
import (
"flag"
"fmt"
- "github.com/apache/beam/sdks/v2/go/pkg/beam/register"
"log"
"math/rand"
"reflect"
"strings"
"testing"
"time"
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/register"
Review Comment:
SGTM. It should be in the group below rather than by itself, but it's not a real problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24625:
URL: https://github.com/apache/beam/pull/24625#issuecomment-1344723839
# [Codecov](https://codecov.io/gh/apache/beam/pull/24625?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24625](https://codecov.io/gh/apache/beam/pull/24625?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1723fc1) into [master](https://codecov.io/gh/apache/beam/commit/0f79b419f8f41c739dab8b14b87c5c355202a48b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f79b41) will **not change** coverage.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## master #24625 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 719 719
Lines 97134 97134
=======================================
Hits 71257 71257
Misses 24529 24529
Partials 1348 1348
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `51.61% <71.42%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/option.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb24uZ28=) | `73.33% <ø> (ø)` | |
| [sdks/go/pkg/beam/options/jobopts/stringSlice.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL2pvYm9wdHMvc3RyaW5nU2xpY2UuZ28=) | `71.42% <0.00%> (ø)` | |
| [.../pkg/beam/runners/dataflow/dataflowlib/messages.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL21lc3NhZ2VzLmdv) | `0.00% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/runners/direct/buffer.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RpcmVjdC9idWZmZXIuZ28=) | `77.46% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/util.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS91dGlsLmdv) | `29.54% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/xlang.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS94bGFuZy5nbw==) | `23.37% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/forward.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9mb3J3YXJkLmdv) | `40.00% <33.33%> (ø)` | |
| [sdks/go/pkg/beam/encoding.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9lbmNvZGluZy5nbw==) | `25.78% <50.00%> (ø)` | |
| [sdks/go/pkg/beam/runners/vet/vet.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ZldC92ZXQuZ28=) | `42.25% <50.00%> (ø)` | |
| [sdks/go/pkg/beam/schema.go](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9zY2hlbWEuZ28=) | `25.00% <50.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/beam/pull/24625/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24625:
URL: https://github.com/apache/beam/pull/24625#issuecomment-1344723385
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #24625: interface{} -> any for remaining references
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #24625:
URL: https://github.com/apache/beam/pull/24625#issuecomment-1344726791
Thanks for sorting this out! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org