You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/12/24 06:06:33 UTC

Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69630/
-----------------------------------------------------------

Review request for ranger, deepak sharma, Madhan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-2313
    https://issues.apache.org/jira/browse/RANGER-2313


Repository: ranger


Description
-------

Tagsync fails to upload tags to Ranger admin if it is invoked using ranger-tagsync-upload.sh script in secure cluster. This is a result of failure to establish kerberos identity in the described scenario.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 49ff76fb2 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java adaa2f935 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 2b4a668b8 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java f0a3fd003 


Diff: https://reviews.apache.org/r/69630/diff/1/


Testing
-------

Tested with local VM


Thanks,

Abhay Kulkarni


Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69630/#review211527
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 24, 2018, 6:06 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69630/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2018, 6:06 a.m.)
> 
> 
> Review request for ranger, deepak sharma, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2313
>     https://issues.apache.org/jira/browse/RANGER-2313
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Tagsync fails to upload tags to Ranger admin if it is invoked using ranger-tagsync-upload.sh script in secure cluster. This is a result of failure to establish kerberos identity in the described scenario.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 49ff76fb2 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java adaa2f935 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 2b4a668b8 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java f0a3fd003 
> 
> 
> Diff: https://reviews.apache.org/r/69630/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with local VM
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69630/#review211571
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 28, 2018, 3:42 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69630/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2018, 3:42 p.m.)
> 
> 
> Review request for ranger, deepak sharma, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2313
>     https://issues.apache.org/jira/browse/RANGER-2313
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Tagsync fails to upload tags to Ranger admin if it is invoked using ranger-tagsync-upload.sh script in secure cluster. This is a result of failure to establish kerberos identity in the described scenario.
> 
> Also, incorrect processing of ENTITY_CREATE and ENTITY_UPDATE notifications causes entities with no associated classifications to create corresponding Service Resource objects in Ranger Admin. Instead, such notifications should be dropped without further processing.
> 
> Atlas REST API to download tagged entities throttles the number of entities returned to 100 even when all entities are requested. Tagsync needs to call this API in a loop until no more entities are returned to ensure that all tagged entities are retrieved.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 49ff76fb2 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java adaa2f935 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 2b4a668b8 
>   tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java f0a3fd003 
> 
> 
> Diff: https://reviews.apache.org/r/69630/diff/3/
> 
> 
> Testing
> -------
> 
> Tested with local VM
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69630/
-----------------------------------------------------------

(Updated Dec. 28, 2018, 3:42 p.m.)


Review request for ranger, deepak sharma, Madhan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Set limit on tagged entities to be searched at a number other than Integer.MAX_VALUE to get around a bug in JanusGraph.


Bugs: RANGER-2313
    https://issues.apache.org/jira/browse/RANGER-2313


Repository: ranger


Description
-------

Tagsync fails to upload tags to Ranger admin if it is invoked using ranger-tagsync-upload.sh script in secure cluster. This is a result of failure to establish kerberos identity in the described scenario.

Also, incorrect processing of ENTITY_CREATE and ENTITY_UPDATE notifications causes entities with no associated classifications to create corresponding Service Resource objects in Ranger Admin. Instead, such notifications should be dropped without further processing.

Atlas REST API to download tagged entities throttles the number of entities returned to 100 even when all entities are requested. Tagsync needs to call this API in a loop until no more entities are returned to ensure that all tagged entities are retrieved.


Diffs (updated)
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 49ff76fb2 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java adaa2f935 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 2b4a668b8 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java f0a3fd003 


Diff: https://reviews.apache.org/r/69630/diff/3/

Changes: https://reviews.apache.org/r/69630/diff/2-3/


Testing
-------

Tested with local VM


Thanks,

Abhay Kulkarni


Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69630/
-----------------------------------------------------------

(Updated Dec. 27, 2018, 5:25 p.m.)


Review request for ranger, deepak sharma, Madhan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Updated description


Bugs: RANGER-2313
    https://issues.apache.org/jira/browse/RANGER-2313


Repository: ranger


Description (updated)
-------

Tagsync fails to upload tags to Ranger admin if it is invoked using ranger-tagsync-upload.sh script in secure cluster. This is a result of failure to establish kerberos identity in the described scenario.

Also, incorrect processing of ENTITY_CREATE and ENTITY_UPDATE notifications causes entities with no associated classifications to create corresponding Service Resource objects in Ranger Admin. Instead, such notifications should be dropped without further processing.

Atlas REST API to download tagged entities throttles the number of entities returned to 100 even when all entities are requested. Tagsync needs to call this API in a loop until no more entities are returned to ensure that all tagged entities are retrieved.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 49ff76fb2 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java adaa2f935 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 2b4a668b8 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java f0a3fd003 


Diff: https://reviews.apache.org/r/69630/diff/2/


Testing
-------

Tested with local VM


Thanks,

Abhay Kulkarni


Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69630/
-----------------------------------------------------------

(Updated Dec. 27, 2018, 4:02 p.m.)


Review request for ranger, deepak sharma, Madhan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Fetch all tagged entities from Atlas.


Bugs: RANGER-2313
    https://issues.apache.org/jira/browse/RANGER-2313


Repository: ranger


Description
-------

Tagsync fails to upload tags to Ranger admin if it is invoked using ranger-tagsync-upload.sh script in secure cluster. This is a result of failure to establish kerberos identity in the described scenario.


Diffs (updated)
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 49ff76fb2 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java adaa2f935 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 2b4a668b8 
  tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java f0a3fd003 


Diff: https://reviews.apache.org/r/69630/diff/2/

Changes: https://reviews.apache.org/r/69630/diff/1-2/


Testing
-------

Tested with local VM


Thanks,

Abhay Kulkarni