You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "simon steiner (JIRA)" <ji...@apache.org> on 2019/03/14 13:54:00 UTC
[jira] [Comment Edited] (FOP-2536) [PATCH] Varying table border
thickness in PDF output
[ https://issues.apache.org/jira/browse/FOP-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792668#comment-16792668 ]
simon steiner edited comment on FOP-2536 at 3/14/19 1:53 PM:
-------------------------------------------------------------
I am seeing compile and checkstyle errors when trying your patch
[javac]fop-core/src/main/java/org/apache/fop/layoutmgr/table/TableLayoutManager.java:660: error: cannot find symbol
[javac] && bpsPrev.getMode() == bpsPrev.getMode()
was (Author: ssteiner1):
I am seeing compile and checkstyle errors when trying your patch
> [PATCH] Varying table border thickness in PDF output
> ----------------------------------------------------
>
> Key: FOP-2536
> URL: https://issues.apache.org/jira/browse/FOP-2536
> Project: FOP
> Issue Type: Improvement
> Components: renderer/pdf
> Reporter: Martin Leitner
> Priority: Major
> Attachments: Polygon.java, extended-patch-FOP-2536.patch, fop-2434-alternative.patch, patch-FOP-2434.diff, table-border-overpaint.pdf, table-border-standard.pdf, table-border.fo, tableBorders.fo, tableBorders_fop_2.0.pdf, tableBorders_fop_2.1.pdf, tableBorders_fop_2.1_AdobeReader_11.png, tableBorders_patched.pdf
>
>
> As already pointed out in a comment to the original issue, this is a problem with the PDF viewers. FOP generates the borders correctly. The viewers render border segments correctly when they are rectangles, but they make mistakes when the segments are more general polygons. In my patch, I am splitting the polygons into rectangles, covering as much of the polygon as possible, write the rectangles to the PDF, then write the remaining triangles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)