You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Sander Striker <st...@apache.org> on 2002/03/05 14:15:26 UTC

FW: [PATCH] server/core.c detab

The mail with the attachement bounced because it was >100k.
Sent in private to Justin, who will hopefully pick it up.

Sander

-----Original Message-----
From: Sander Striker [mailto:striker@apache.org]
Sent: 05 March 2002 14:00
To: dev@httpd.apache.org
Subject: [PATCH] server/core.c detab


Hi,

More detab and other style stuff.  This time
for server/core.c.

I encountered this in there:

Line 661: AP_DECLARE(const char *) ap_document_root(request_rec *r) /* Don't use this! */

If we shouldn't use it, why is it still here?


And:

Line 691: /* Should probably just get rid of this... the only code that cares is
           * part of the core anyway (and in fact, it isn't publicised to other
           * modules).
           */

Patch attached yadda yadda yadda.

Sander


RE: [PATCH] server/core.c detab

Posted by Sander Striker <st...@apache.org>.
> The mail with the attachement bounced because it was >100k.

If anyone wants it, please holler.  It wasn't all simple
find-replace, so better not wait until conflicts arise ;)
 
Sander
 
> -----Original Message-----
> From: Sander Striker [mailto:striker@apache.org]
> Sent: 05 March 2002 14:00
> To: dev@httpd.apache.org
> Subject: [PATCH] server/core.c detab
> 
> 
> Hi,
> 
> More detab and other style stuff.  This time
> for server/core.c.
> 
> I encountered this in there:
> 
> Line 661: AP_DECLARE(const char *) ap_document_root(request_rec *r) /* Don't use this! */
> 
> If we shouldn't use it, why is it still here?
> 
> 
> And:
> 
> Line 691: /* Should probably just get rid of this... the only code that cares is
>            * part of the core anyway (and in fact, it isn't publicised to other
>            * modules).
>            */
> 
> Patch attached yadda yadda yadda.
> 
> Sander
> 
> 
>