You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/09 06:28:09 UTC

Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1564
    https://issues.apache.org/jira/browse/RANGER-1564


Repository: ranger


Description
-------

The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh.


Diffs
-----

  agents-common/scripts/enable-agent.sh 14e9577 


Diff: https://reviews.apache.org/r/59079/diff/1/


Testing
-------


Thanks,

pengjianhua

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

Posted by pengjianhua <pe...@zte.com.cn>.

> On May 9, 2017, 3:27 p.m., Colm O hEigeartaigh wrote:
> > There are some whitespace issues when I look at the patch in vi. The end "fi" is not aligned with "then". I also think the "do" should be underneath the "for" as per the other examples in the file.
> > 
> > Have you installed a plugin with this change to make sure it works correctly?

I installed the hbase and hive plugin to test the function. The test result shown that the function worked correctly. 
I had rebuilt the patch and verify it using git apply --check and git am --signoff command before updated the patch.


- pengjianhua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/#review174321
-----------------------------------------------------------


On May 10, 2017, 8:03 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59079/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 8:03 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1564
>     https://issues.apache.org/jira/browse/RANGER-1564
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh 14e9577 
> 
> 
> Diff: https://reviews.apache.org/r/59079/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/#review174321
-----------------------------------------------------------



There are some whitespace issues when I look at the patch in vi. The end "fi" is not aligned with "then". I also think the "do" should be underneath the "for" as per the other examples in the file.

Have you installed a plugin with this change to make sure it works correctly?

- Colm O hEigeartaigh


On May 9, 2017, 6:28 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59079/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 6:28 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1564
>     https://issues.apache.org/jira/browse/RANGER-1564
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh 14e9577 
> 
> 
> Diff: https://reviews.apache.org/r/59079/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/#review174300
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On May 9, 2017, 6:28 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59079/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 6:28 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1564
>     https://issues.apache.org/jira/browse/RANGER-1564
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh 14e9577 
> 
> 
> Diff: https://reviews.apache.org/r/59079/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/#review174429
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 10, 2017, 8:03 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59079/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 8:03 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1564
>     https://issues.apache.org/jira/browse/RANGER-1564
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh.
> 
> 
> Diffs
> -----
> 
>   agents-common/scripts/enable-agent.sh 14e9577 
> 
> 
> Diff: https://reviews.apache.org/r/59079/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59079/
-----------------------------------------------------------

(Updated May 10, 2017, 8:03 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1564
    https://issues.apache.org/jira/browse/RANGER-1564


Repository: ranger


Description
-------

The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh.


Diffs (updated)
-----

  agents-common/scripts/enable-agent.sh 14e9577 


Diff: https://reviews.apache.org/r/59079/diff/2/

Changes: https://reviews.apache.org/r/59079/diff/1-2/


Testing
-------


Thanks,

pengjianhua