You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/17 01:27:07 UTC

[GitHub] [incubator-eventmesh] jonyangx opened a new pull request, #2617: [ISSUE #2600] Method calls equals on an enum instance [SessionSender]

jonyangx opened a new pull request, #2617:
URL: https://github.com/apache/incubator-eventmesh/pull/2617

   
   Fixes #2600 .
   
   ### Motivation
   
   Method calls equals on an enum instance [SessionSender]
   
   ### Modifications
   
   refactor
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java 
   
   ### Documentation
   
   - Does this pull request introduce a new feature? ( no)
   - If yes, how is the feature documented? ( not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2617: [ISSUE #2600] Method calls equals on an enum instance [SessionSender]

Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2617:
URL: https://github.com/apache/incubator-eventmesh/pull/2617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2617: [ISSUE #2600] Method calls equals on an enum instance [SessionSender]

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2617:
URL: https://github.com/apache/incubator-eventmesh/pull/2617#issuecomment-1355951149

   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2617](https://codecov.io/gh/apache/incubator-eventmesh/pull/2617?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d510bdd) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/fd181e8805e5e0b31eae2f4e830c9de21f9d14a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd181e8) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #2617   +/-   ##
   =========================================
     Coverage     11.83%   11.83%           
     Complexity      900      900           
   =========================================
     Files           476      476           
     Lines         27198    27198           
     Branches       2814     2814           
   =========================================
     Hits           3219     3219           
     Misses        23691    23691           
     Partials        288      288           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rotocol/tcp/client/session/send/SessionSender.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2617/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3NlbmQvU2Vzc2lvblNlbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org