You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "YongGang Cao (JIRA)" <ji...@apache.org> on 2015/12/05 01:41:10 UTC
[jira] [Updated] (SPARK-12153) Word2Vec uses a fixed length for
sentences which is not reasonable for reality, and similarity functions and
fields are not accessible
[ https://issues.apache.org/jira/browse/SPARK-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
YongGang Cao updated SPARK-12153:
---------------------------------
Description:
sentence boundary matters for sliding window, we shouldn't train model from a window across sentences. the current 100 word as a hard split for sentences doesn't really make sense.
And the cosinesimilarity functions is private which is useless for caller.
we may need to access the vocabulary and wordindex table as well, those need getters
I made changes to address above issues.
here is the pull request: https://github.com/apache/spark/pull/10152
was:
sentence boundary matters for sliding window, we shouldn't train model from a window across sentences. the current 100 word as a hard split for sentences doesn't really make sense.
And the cosinesimilarity functions is private which is useless for caller.
we may need to access the vocabulary and wordindex table as well, those need getters
I made changes to address above issues. will send out pull request for your review.
> Word2Vec uses a fixed length for sentences which is not reasonable for reality, and similarity functions and fields are not accessible
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SPARK-12153
> URL: https://issues.apache.org/jira/browse/SPARK-12153
> Project: Spark
> Issue Type: Improvement
> Components: MLlib
> Affects Versions: 1.5.2
> Reporter: YongGang Cao
> Priority: Minor
> Labels: patch
>
> sentence boundary matters for sliding window, we shouldn't train model from a window across sentences. the current 100 word as a hard split for sentences doesn't really make sense.
> And the cosinesimilarity functions is private which is useless for caller.
> we may need to access the vocabulary and wordindex table as well, those need getters
> I made changes to address above issues.
> here is the pull request: https://github.com/apache/spark/pull/10152
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org