[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #10117: Add SQL Definition for `ALTER SESSION` of Oracle Database

[GitBox <gi...@apache.org>]

ThanoshanMV commented on a change in pull request #10117:
URL: https://github.com/apache/shardingsphere/pull/10117#discussion_r616324236



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -998,3 +998,91 @@ supplementalLogGrpClause
 supplementalIdKeyClause
     : DATA LP_ (ALL | PRIMARY KEY | UNIQUE | FOREIGN KEY) (COMMA (ALL | PRIMARY KEY | UNIQUE | FOREIGN KEY))* RP_ COLUMNS
     ;
+
+alterSession
+    : ALTER SESSION alterSessionOption
+    ;
+
+alterSessionOption
+    : adviseClause
+    | closeDatabaseLinkClause
+    | commitInProcedureClause
+    | securiyClause
+    | parallelExecutionClause
+    | resumableClause
+    | shardDdlClause
+    | SYNC WITH PRIMARY

Review comment:
       Yes, we can put it in a rule. I'll put it in a rule like: 
   ```
   syncWithPrimaryClause: SYNC WITH PRIMARY
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org