You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/11/05 06:04:28 UTC
[PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
kou opened a new pull request, #44644:
URL: https://github.com/apache/arrow/pull/44644
### Rationale for this change
TODO
### What changes are included in this PR?
TODO
### Are these changes tested?
TODO
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2472736690
@github-actions crossbow submit -g wheel java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456542484
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460744530
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461132807
@github-actions crossbow submit wheel-windows-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Actions cache for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459470048
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2462099335
@github-actions crossbow submit wheel-manylinux-2014-cp39-cp39-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2466218336
@github-actions crossbow submit -g wheel java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459505051
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460880375
Revision: 00a007f8fce89c716bf8ed65746c61cbf83cff8d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4a3af5f17f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4a3af5f17f)
|Task|Status|
|----|------|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11712683518/job/32623909860)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460853995
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1841196808
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -69,36 +69,47 @@ RUN /arrow/ci/scripts/install_ccache.sh ${ccache} /usr/local
ARG vcpkg
COPY ci/vcpkg/*.patch \
ci/vcpkg/*linux*.cmake \
+ ci/vcpkg/vcpkg.json \
arrow/ci/vcpkg/
COPY ci/scripts/install_vcpkg.sh \
arrow/ci/scripts/
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ PATH="${PATH}:${VCPKG_ROOT}" \
VCPKG_DEFAULT_TRIPLET=${arch_short}-linux-static-${build_type} \
- VCPKG_FEATURE_FLAGS="manifests"
-
-RUN arrow/ci/scripts/install_vcpkg.sh ${VCPKG_ROOT} ${vcpkg}
-ENV PATH="${PATH}:${VCPKG_ROOT}"
-
-COPY ci/vcpkg/vcpkg.json arrow/ci/vcpkg/
-# cannot use the S3 feature here because while aws-sdk-cpp=1.9.160 contains
-# ssl related fixes as well as we can patch the vcpkg portfile to support
-# arm machines it hits ARROW-15141 where we would need to fall back to 1.8.186
-# but we cannot patch those portfiles since vcpkg-tool handles the checkout of
-# previous versions => use bundled S3 build
-RUN vcpkg install \
+ VCPKG_FEATURE_FLAGS="manifests" \
+ VCPKG_FORCE_SYSTEM_BINARIES=1 \
+ VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg
+# For --mount=type=secret: GITHUB_TOKEN is only secret data but we use
+# --mount=type=secret for GITHUB_REPOSITORY_OWNER and
+# VCPKG_BINARY_SOURCES too. Because we don't want to store all of
+# them to built image for easy to reuse built image cache.
Review Comment:
Thanks!
English suggestion is always helpful to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461368752
Revision: 68c2f4536912ae3716ce66eb6bd5cc8a7f96412b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-615a598afe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-615a598afe)
|Task|Status|
|----|------|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11717280106/job/32636684118)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461710058
@github-actions crossbow submit -g wheel java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461108551
@github-actions crossbow submit wheel-windows-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456425639
Revision: 554488b4dd7969bd35eff386a1bd80119c8836b7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1a2a233a9e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1a2a233a9e)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11679459278/job/32520568411)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456309154
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461096260
@github-actions crossbow submit wheel-macos-monterey-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460877053
@github-actions crossbow submit wheel-manylinux-2014-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2465994065
Revision: 63d255c9d3f52c1f4e40da434d89713cfb9749ef
Submitted crossbow builds: [ursacomputing/crossbow @ actions-267447c157](https://github.com/ursacomputing/crossbow/branches/all?query=actions-267447c157)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/11752445084/job/32743989942)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1835728127
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -75,11 +78,15 @@ COPY ci/scripts/install_vcpkg.sh \
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ GITHUB_REPOSITORY_OWNER="${GITHUB_REPOSITORY_OWNER}" \
+ GITHUB_TOKEN="${GITHUB_TOKEN}" \
+ VCPKG_BINARY_SOURCES="${VCPKG_BINARY_SOURCES}" \
VCPKG_DEFAULT_TRIPLET=${arch_short}-linux-static-${build_type} \
- VCPKG_FEATURE_FLAGS="manifests"
+ VCPKG_FEATURE_FLAGS="manifests" \
+ VCPKG_FORCE_SYSTEM_BINARIES=1 \
+ VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg
+# TODO: Use --mount=type=secret for GITHUB_TOKEN
Review Comment:
Is there an issue open for this? If so, can we mention the GH issue number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1835793903
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -75,11 +78,15 @@ COPY ci/scripts/install_vcpkg.sh \
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ GITHUB_REPOSITORY_OWNER="${GITHUB_REPOSITORY_OWNER}" \
+ GITHUB_TOKEN="${GITHUB_TOKEN}" \
+ VCPKG_BINARY_SOURCES="${VCPKG_BINARY_SOURCES}" \
VCPKG_DEFAULT_TRIPLET=${arch_short}-linux-static-${build_type} \
- VCPKG_FEATURE_FLAGS="manifests"
+ VCPKG_FEATURE_FLAGS="manifests" \
+ VCPKG_FORCE_SYSTEM_BINARIES=1 \
+ VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg
+# TODO: Use --mount=type=secret for GITHUB_TOKEN
Review Comment:
No. I'll open it when this is merged or someone agrees that we should do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1841206177
##########
ci/scripts/install_vcpkg.sh:
##########
@@ -53,4 +53,33 @@ if [ -f "${vcpkg_ports_patch}" ]; then
echo "Patch successfully applied to the VCPKG port files!"
fi
+if [ -n "${GITHUB_TOKEN:-}" ] && \
+ [ -n "${GITHUB_REPOSITORY_OWNER:-}" ] && \
+ [ "${VCPKG_BINARY_SOURCES:-}" = "clear;nuget,GitHub,readwrite" ] ; then
Review Comment:
If `VCPKG_BINARY_SOURCES` is not `clear;nuget,GitHub,readwrite` (including not present case on `manylinux2014_aarch64`), we don't configure NuGet automatically.
Ignoring not `clear;nuget,GitHub,readwrite` `VCPKG_BINARY_SOURCES` is for using other cache. For example, we may want to use local file cache for local `archery docker run`. But it's out-of-scope of this PR and it's not tested. If we need it, we can work on it as a separated task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456467527
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1835550833
##########
ci/docker/python-wheel-windows-vs2019.dockerfile:
##########
@@ -34,12 +34,18 @@ RUN setx path "%path%;C:\Program Files\Git\usr\bin"
#
# Compiling vcpkg itself from a git tag doesn't work anymore since vcpkg has
# started to ship precompiled binaries for the vcpkg-tool.
+ARG GITHUB_REPOSITORY_OWNER
+ARG GITHUB_TOKEN
ARG vcpkg
COPY ci/vcpkg/*.patch \
ci/vcpkg/*windows*.cmake \
arrow/ci/vcpkg/
COPY ci/scripts/install_vcpkg.sh arrow/ci/scripts/
-ENV VCPKG_ROOT=C:\\vcpkg
+ENV GITHUB_REPOSITORY_OWNER="${GITHUB_REPOSITORY_OWNER}" \
+ GITHUB_TOKEN="${GITHUB_TOKEN}" \
+ VCPKG_BINARY_SOURCES="clear;nuget,GitHub,readwrite" \
+ VCPKG_ROOT=C:\\vcpkg
+# TODO: Use --mount=type=secret for GITHUB_TOKEN
Review Comment:
I'll work on this in a follow-up task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461098437
Revision: d865f52e2750a629acc898839028b74f8ef0a161
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7cfd1d2a87](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7cfd1d2a87)
|Task|Status|
|----|------|
|wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11714492986/job/32629271412)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460765348
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461110748
Revision: 5a7981a9ae73df2e10760b0452b48f07ea3713a8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c9231388ac](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c9231388ac)
|Task|Status|
|----|------|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11714631471/job/32629639755)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2463648835
Revision: 6edf62e61d3bf23b62e5b889ee552a677f149d17
Submitted crossbow builds: [ursacomputing/crossbow @ actions-488719c722](https://github.com/ursacomputing/crossbow/branches/all?query=actions-488719c722)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132823/job/32692309740)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132527/job/32692306429)|
|wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735133223/job/32692309578)|
|wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132686/job/32692307411)|
|wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132897/job/32692308796)|
|wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132679/job/32692307392)|
|wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132526/job/32692306334)|
|wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132699/job/32692307588)|
|wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132802/job/32692308251)|
|wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132914/job/32692308786)|
|wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132883/job/32692308613)|
|wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132819/job/32692308024)|
|wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132712/job/32692307694)|
|wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132537/job/32692306631)|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132521/job/32692306585)|
|wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132985/job/32692309097)|
|wheel-manylinux-2-28-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132907/job/32692308879)|
|wheel-manylinux-2-28-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132539/job/32692306286)|
|wheel-manylinux-2-28-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132517/job/32692306359)|
|wheel-manylinux-2-28-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132654/job/32692307391)|
|wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132936/job/32692308949)|
|wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132636/job/32692307190)|
|wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132879/job/32692308587)|
|wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132578/job/32692306844)|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132696/job/32692307460)|
|wheel-manylinux-2-28-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132600/job/32692306880)|
|wheel-manylinux-2014-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132735/job/32692307851)|
|wheel-manylinux-2014-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132860/job/32692308471)|
|wheel-manylinux-2014-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132800/job/32692308112)|
|wheel-manylinux-2014-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132893/job/32692308768)|
|wheel-manylinux-2014-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132626/job/32692307031)|
|wheel-manylinux-2014-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132994/job/32692309244)|
|wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132690/job/32692307555)|
|wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132796/job/32692308113)|
|wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132650/job/32692307237)|
|wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132562/job/32692306720)|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132633/job/32692307193)|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132514/job/32692306296)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735133097/job/32692309379)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132762/job/32692307942)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132733/job/32692307877)|
|wheel-windows-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735133068/job/32692309373)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11735132740/job/32692307766)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1836961655
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -75,11 +78,15 @@ COPY ci/scripts/install_vcpkg.sh \
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ GITHUB_REPOSITORY_OWNER="${GITHUB_REPOSITORY_OWNER}" \
+ GITHUB_TOKEN="${GITHUB_TOKEN}" \
Review Comment:
I don't think we should merge it like this, it bakes the token into the image. Even if the token is ephemeral it could still be abused (it lives a little longer than the job) and crossbow jobs have full permissions because they don't run as external pull requests.
In addition if people test/build the image locally it could leak their token as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2463645994
@github-actions crossbow submit -g wheel java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2465840095
Revision: c75a11773c5d03194be4524a9ef67e930942b4d9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-422eaa7713](https://github.com/ursacomputing/crossbow/branches/all?query=actions-422eaa7713)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/11750381046/job/32738525233)|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11750381024/job/32738524180)|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11750381023/job/32738524278)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2465837760
@github-actions crossbow submit java-jars wheel-manylinux-2014-cp39-cp39-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461134785
Revision: 881899948a769ddfe7f9019b9cb6d9aa9d015eda
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2a7277a14b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2a7277a14b)
|Task|Status|
|----|------|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11714901862/job/32630366021)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456438635
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460769334
Revision: db1c666da549a2920b1c11389f67ed66beab5b7a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3ad2ff1cde](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3ad2ff1cde)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11711777485/job/32621035842)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2472722030
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2478367994
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456315793
Revision: f4016841c4cd85c7e1707cc9a0097fac30cdc393
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7972adf92b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7972adf92b)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11678556857/job/32518212318)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456313058
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456442373
Revision: 34a79f5adcc3367aff950609174dd7d6e30f6aa2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-531eb202a6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-531eb202a6)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11679600864/job/32520942156)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2479491367
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit df40f7ad46f0097a874025884fa1677169012b97.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/33056301480) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461716062
Revision: 3758736adc728951b91be35922d4535f15e05534
Submitted crossbow builds: [ursacomputing/crossbow @ actions-61d5a7d744](https://github.com/ursacomputing/crossbow/branches/all?query=actions-61d5a7d744)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037749/job/32644531277)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037692/job/32644526442)|
|wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037912/job/32644527930)|
|wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037415/job/32644524671)|
|wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038001/job/32644528239)|
|wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037947/job/32644528196)|
|wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038106/job/32644529210)|
|wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038285/job/32644530323)|
|wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037646/job/32644526223)|
|wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038161/job/32644529443)|
|wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037951/job/32644528220)|
|wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037693/job/32644526491)|
|wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038051/job/32644528896)|
|wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038177/job/32644529739)|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037519/job/32644525192)|
|wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037936/job/32644527837)|
|wheel-manylinux-2-28-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037516/job/32644525260)|
|wheel-manylinux-2-28-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037869/job/32644527497)|
|wheel-manylinux-2-28-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038287/job/32644529756)|
|wheel-manylinux-2-28-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038341/job/32644530424)|
|wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037616/job/32644526224)|
|wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037324/job/32644524076)|
|wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037568/job/32644525880)|
|wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037599/job/32644525982)|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037866/job/32644527433)|
|wheel-manylinux-2-28-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037446/job/32644525017)|
|wheel-manylinux-2014-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037976/job/32644528216)|
|wheel-manylinux-2014-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037388/job/32644524060)|
|wheel-manylinux-2014-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038266/job/32644530157)|
|wheel-manylinux-2014-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037326/job/32644523688)|
|wheel-manylinux-2014-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038239/job/32644530122)|
|wheel-manylinux-2014-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038049/job/32644528574)|
|wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037264/job/32644523681)|
|wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037925/job/32644527821)|
|wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037444/job/32644524897)|
|wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038271/job/32644529972)|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037460/job/32644525447)|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038022/job/32644528536)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037238/job/32644523646)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037366/job/32644524047)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720038118/job/32644529007)|
|wheel-windows-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037452/job/32644525225)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11720037617/job/32644526183)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2465993294
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2466219661
Revision: 63d255c9d3f52c1f4e40da434d89713cfb9749ef
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e75f942933](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e75f942933)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723675/job/32753164244)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723488/job/32753162692)|
|wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723648/job/32753163290)|
|wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723633/job/32753163291)|
|wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723457/job/32753162615)|
|wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723754/job/32753163831)|
|wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723695/job/32753163563)|
|wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723405/job/32753162592)|
|wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723373/job/32753162415)|
|wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723566/job/32753162897)|
|wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723366/job/32753162414)|
|wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723630/job/32753163260)|
|wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723591/job/32753163111)|
|wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723674/job/32753163404)|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723379/job/32753162450)|
|wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723479/job/32753162670)|
|wheel-manylinux-2-28-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723765/job/32753163890)|
|wheel-manylinux-2-28-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723560/job/32753162894)|
|wheel-manylinux-2-28-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723576/job/32753163053)|
|wheel-manylinux-2-28-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723490/job/32753162694)|
|wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723651/job/32753163312)|
|wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723572/job/32753162958)|
|wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723326/job/32753162221)|
|wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723293/job/32753162214)|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723594/job/32753163207)|
|wheel-manylinux-2-28-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723734/job/32753163751)|
|wheel-manylinux-2014-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723590/job/32753163126)|
|wheel-manylinux-2014-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723788/job/32753163970)|
|wheel-manylinux-2014-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723289/job/32753162227)|
|wheel-manylinux-2014-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723704/job/32753163573)|
|wheel-manylinux-2014-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723687/job/32753163594)|
|wheel-manylinux-2014-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723295/job/32753162215)|
|wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723501/job/32753162784)|
|wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723370/job/32753162391)|
|wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723714/job/32753163609)|
|wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723398/job/32753162553)|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723549/job/32753162907)|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723688/job/32753163551)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723719/job/32753163625)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723577/job/32753163072)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723668/job/32753163382)|
|wheel-windows-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723753/job/32753163773)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11756723574/job/32753163014)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2458501595
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2458827743
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456422329
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1839959670
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -69,36 +69,47 @@ RUN /arrow/ci/scripts/install_ccache.sh ${ccache} /usr/local
ARG vcpkg
COPY ci/vcpkg/*.patch \
ci/vcpkg/*linux*.cmake \
+ ci/vcpkg/vcpkg.json \
arrow/ci/vcpkg/
COPY ci/scripts/install_vcpkg.sh \
arrow/ci/scripts/
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ PATH="${PATH}:${VCPKG_ROOT}" \
VCPKG_DEFAULT_TRIPLET=${arch_short}-linux-static-${build_type} \
- VCPKG_FEATURE_FLAGS="manifests"
-
-RUN arrow/ci/scripts/install_vcpkg.sh ${VCPKG_ROOT} ${vcpkg}
-ENV PATH="${PATH}:${VCPKG_ROOT}"
-
-COPY ci/vcpkg/vcpkg.json arrow/ci/vcpkg/
-# cannot use the S3 feature here because while aws-sdk-cpp=1.9.160 contains
-# ssl related fixes as well as we can patch the vcpkg portfile to support
-# arm machines it hits ARROW-15141 where we would need to fall back to 1.8.186
-# but we cannot patch those portfiles since vcpkg-tool handles the checkout of
-# previous versions => use bundled S3 build
-RUN vcpkg install \
+ VCPKG_FEATURE_FLAGS="manifests" \
+ VCPKG_FORCE_SYSTEM_BINARIES=1 \
+ VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg
+# For --mount=type=secret: GITHUB_TOKEN is only secret data but we use
+# --mount=type=secret for GITHUB_REPOSITORY_OWNER and
+# VCPKG_BINARY_SOURCES too. Because we don't want to store all of
+# them to built image for easy to reuse built image cache.
Review Comment:
Just a minor grammar suggestion
```suggestion
# For --mount=type=secret: The GITHUB_TOKEN is the only real secret but we use
# --mount=type=secret for GITHUB_REPOSITORY_OWNER and
# VCPKG_BINARY_SOURCES too because we don't want to store them
# into the built image in order to easily reuse the built image cache.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2472725744
Revision: 52b6ee9b1e8e1ddc491cd0bdde5fe2538b9062e9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-806e7b25fb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-806e7b25fb)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812874343/job/32908819641)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1839746037
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -75,11 +78,15 @@ COPY ci/scripts/install_vcpkg.sh \
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ GITHUB_REPOSITORY_OWNER="${GITHUB_REPOSITORY_OWNER}" \
+ GITHUB_TOKEN="${GITHUB_TOKEN}" \
Review Comment:
OK. I've implemented `--mount=type=secret` support in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460748552
Revision: 0378e7997944e20d36213f6772d2528fa8eb0267
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8d57352c40](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8d57352c40)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11711617223/job/32620513005)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2462103989
Revision: 58a6f15c72086994f8e724b71358304d2cbeba0d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-43e8445da4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-43e8445da4)
|Task|Status|
|----|------|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11722890311/job/32653385899)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Actions cache for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459455328
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2461362482
@github-actions crossbow submit wheel-windows-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2460857286
Revision: 00a007f8fce89c716bf8ed65746c61cbf83cff8d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a8277982cb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a8277982cb)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11712487171/job/32623268699)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456547105
Revision: e94314b350039cf7cb609b9a648951c84bf7ece7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d62698d0c4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d62698d0c4)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11680374151/job/32523233532)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Actions cache for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2459487806
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456310370
```
Failed to render template `python-wheels/github.linux.yml` with UndefinedError: 'secrets' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/11678507794
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456308229
:warning: GitHub issue #43951 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2456471502
Revision: 2cb4b09701e27571b6f0b056ff8262ae0ec63502
Submitted crossbow builds: [ursacomputing/crossbow @ actions-eb1f976630](https://github.com/ursacomputing/crossbow/branches/all?query=actions-eb1f976630)
|Task|Status|
|----|------|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11679807694/job/32521535397)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #44644:
URL: https://github.com/apache/arrow/pull/44644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #44644:
URL: https://github.com/apache/arrow/pull/44644#discussion_r1839965186
##########
ci/scripts/install_vcpkg.sh:
##########
@@ -53,4 +53,33 @@ if [ -f "${vcpkg_ports_patch}" ]; then
echo "Patch successfully applied to the VCPKG port files!"
fi
+if [ -n "${GITHUB_TOKEN:-}" ] && \
+ [ -n "${GITHUB_REPOSITORY_OWNER:-}" ] && \
+ [ "${VCPKG_BINARY_SOURCES:-}" = "clear;nuget,GitHub,readwrite" ] ; then
Review Comment:
in which case would `VCPKG_BINARY_SOURCES` be different to `clear;nuget,GitHub,readwrite`? on `manylinux2014_aarch64` this wouldn't be present but not different, right?
##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -69,36 +69,47 @@ RUN /arrow/ci/scripts/install_ccache.sh ${ccache} /usr/local
ARG vcpkg
COPY ci/vcpkg/*.patch \
ci/vcpkg/*linux*.cmake \
+ ci/vcpkg/vcpkg.json \
arrow/ci/vcpkg/
COPY ci/scripts/install_vcpkg.sh \
arrow/ci/scripts/
ENV VCPKG_ROOT=/opt/vcpkg
ARG build_type=release
ENV CMAKE_BUILD_TYPE=${build_type} \
- VCPKG_FORCE_SYSTEM_BINARIES=1 \
- VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \
+ PATH="${PATH}:${VCPKG_ROOT}" \
VCPKG_DEFAULT_TRIPLET=${arch_short}-linux-static-${build_type} \
- VCPKG_FEATURE_FLAGS="manifests"
-
-RUN arrow/ci/scripts/install_vcpkg.sh ${VCPKG_ROOT} ${vcpkg}
-ENV PATH="${PATH}:${VCPKG_ROOT}"
-
-COPY ci/vcpkg/vcpkg.json arrow/ci/vcpkg/
-# cannot use the S3 feature here because while aws-sdk-cpp=1.9.160 contains
-# ssl related fixes as well as we can patch the vcpkg portfile to support
-# arm machines it hits ARROW-15141 where we would need to fall back to 1.8.186
-# but we cannot patch those portfiles since vcpkg-tool handles the checkout of
-# previous versions => use bundled S3 build
-RUN vcpkg install \
+ VCPKG_FEATURE_FLAGS="manifests" \
+ VCPKG_FORCE_SYSTEM_BINARIES=1 \
+ VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg
+# For --mount=type=secret: GITHUB_TOKEN is only secret data but we use
+# --mount=type=secret for GITHUB_REPOSITORY_OWNER and
+# VCPKG_BINARY_SOURCES too. Because we don't want to store all of
+# them to built image for easy to reuse built image cache.
Review Comment:
Just a minor grammar suggestion
```suggestion
# For --mount=type=secret: the GITHUB_TOKEN is the only real secret but we use
# --mount=type=secret for GITHUB_REPOSITORY_OWNER and
# VCPKG_BINARY_SOURCES too because we don't want to store them
# into the built image in order to easily reuse the built image cache.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43951: [CI][Python] Use GitHub Packages for vcpkg cache [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44644:
URL: https://github.com/apache/arrow/pull/44644#issuecomment-2472741684
Revision: 52b6ee9b1e8e1ddc491cd0bdde5fe2538b9062e9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f4d0e5be13](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f4d0e5be13)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979576/job/32909136143)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979478/job/32909131648)|
|wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978876/job/32909128402)|
|wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979041/job/32909129558)|
|wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979880/job/32909134443)|
|wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979613/job/32909133103)|
|wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979301/job/32909132434)|
|wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979450/job/32909132638)|
|wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979449/job/32909132743)|
|wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979509/job/32909131941)|
|wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978861/job/32909128083)|
|wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978904/job/32909128312)|
|wheel-macos-monterey-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978976/job/32909129200)|
|wheel-macos-monterey-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979368/job/32909131824)|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979461/job/32909133127)|
|wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979179/job/32909129808)|
|wheel-manylinux-2-28-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979113/job/32909129817)|
|wheel-manylinux-2-28-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979722/job/32909134299)|
|wheel-manylinux-2-28-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979043/job/32909129567)|
|wheel-manylinux-2-28-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978920/job/32909128048)|
|wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979074/job/32909129565)|
|wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979220/job/32909130503)|
|wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979020/job/32909129574)|
|wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979486/job/32909132709)|
|wheel-manylinux-2-28-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978844/job/32909128031)|
|wheel-manylinux-2-28-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979414/job/32909132449)|
|wheel-manylinux-2014-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979529/job/32909132948)|
|wheel-manylinux-2014-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979355/job/32909131620)|
|wheel-manylinux-2014-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979271/job/32909131069)|
|wheel-manylinux-2014-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979391/job/32909132443)|
|wheel-manylinux-2014-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979741/job/32909134481)|
|wheel-manylinux-2014-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978873/job/32909127983)|
|wheel-manylinux-2014-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979226/job/32909130397)|
|wheel-manylinux-2014-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979419/job/32909131896)|
|wheel-manylinux-2014-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979696/job/32909134239)|
|wheel-manylinux-2014-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979521/job/32909132876)|
|wheel-manylinux-2014-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979695/job/32909132129)|
|wheel-manylinux-2014-cp39-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979142/job/32909129852)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979224/job/32909130441)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979803/job/32909134432)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979272/job/32909131155)|
|wheel-windows-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812978934/job/32909128980)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/11812979297/job/32909131685)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org