[GitHub] [activemq-nms-amqp] Havret edited a comment on pull request #59: AMQNET-656 failover stalls without reconnecting in some cases - ensure an await statement is not inside a lock statement

[GitBox <gi...@apache.org>]

Havret edited a comment on pull request #59:
URL: https://github.com/apache/activemq-nms-amqp/pull/59#issuecomment-780173091


   I'm not sure if this solve anything. Currently you will leave lock on first await. With the proposed fix you will leave it instantly. In either case lock doesn't work as it should. I'm not sure why https://issues.apache.org/jira/browse/AMQNET-626 was closed, so I reopened it. 
   
   As I said in https://github.com/apache/activemq-nms-amqp/pull/45 
   
   > I think we should revisit this part of code (mainly TriggerReconnectionAttempt) after we hopefully deliver the initial release. Calling async method without await or GetResult() is always a red flag.
   
   This was a bit too naively ported from Java and definitely requires a second look. A more reliable implementation might look as follows: https://github.com/Havret/dotnet-activemq-artemis-client/blob/master/src/ActiveMQ.Artemis.Client/AutoRecovering/AutoRecoveringConnection.cs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org