[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34757: [SPARK-37504][PYTHON] Pyspark create SparkSession with existed session should not pass static conf

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #34757:
URL: https://github.com/apache/spark/pull/34757#discussion_r759838437



##########
File path: python/pyspark/sql/session.py
##########
@@ -278,7 +278,10 @@ def getOrCreate(self) -> "SparkSession":
                     # by all sessions.
                     session = SparkSession(sc, options=self._options)
                 for key, value in self._options.items():
-                    session._jsparkSession.sessionState().conf().setConfString(key, value)
+                    if not session._jvm.org.apache.spark.sql.internal.SQLConf.isStaticConfigKey(

Review comment:
       Current code's behavior should be consistent with scala code path. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org