You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/13 08:55:58 UTC

[GitHub] [hudi] boneanxs opened a new pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

boneanxs opened a new pull request #4586:
URL: https://github.com/apache/hudi/pull/4586


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   When using structure streaming in spark3, the error would throw:
   
   ```java
   Exception in thread "stream execution thread for testHudi [id = 463b211d-50a1-46b2-b304-589a9e1d05bb, runId = 636aaf61-f360-4ada-80b4-353d77e52ccb]" java.lang.NoClassDefFoundError: Could not initialize class org.apache.spark.sql.hudi.streaming.HoodieSourceOffset$
   	at org.apache.spark.sql.hudi.streaming.HoodieSourceOffset.json(HoodieSourceOffset.scala:30)
   	at org.apache.spark.sql.connector.read.streaming.Offset.toString(Offset.java:64)
   	at java.lang.String.valueOf(String.java:2994)
   	at java.lang.StringBuilder.append(StringBuilder.java:131)
   	at org.apache.spark.sql.execution.streaming.StreamProgress.$anonfun$toString$1(StreamProgress.scala:39)
   	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
   	at scala.collection.immutable.HashMap$HashMap1.foreach(HashMap.scala:234)
   	at scala.collection.TraversableLike.map(TraversableLike.scala:238)
   	at scala.collection.TraversableLike.map$(TraversableLike.scala:231)
   	at scala.collection.AbstractTraversable.map(Traversable.scala:108)
   	at org.apache.spark.sql.execution.streaming.StreamProgress.toString(StreamProgress.scala:39)
   	at java.lang.String.valueOf(String.java:2994)
   	at java.lang.StringBuilder.append(StringBuilder.java:131)
   	at org.apache.spark.sql.execution.streaming.StreamExecution.toDebugString(StreamExecution.scala:595)
   	at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:352)
   	at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:244)
   
   ```
   
   This is the incompatible issue of  ScalaObjectMapper under scala_2.11 and scala_2.12, so simply remove this.
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785442620



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -45,17 +45,21 @@ case class HoodieSourceOffset(commitTime: String) extends Offset {
 
 
 object HoodieSourceOffset {
-  val mapper = new ObjectMapper with ScalaObjectMapper
-  mapper.setSerializationInclusion(Include.NON_ABSENT)
-  mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
-  mapper.registerModule(DefaultScalaModule)
+
+  lazy val mapper: ObjectMapper = {
+    val _mapper = new ObjectMapper
+    _mapper.setSerializationInclusion(Include.NON_ABSENT)
+    _mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+    _mapper.registerModule(DefaultScalaModule)
+    _mapper
+  }
 
   def toJson(offset: HoodieSourceOffset): String = {
     mapper.writeValueAsString(offset)
   }
 
   def fromJson(json: String): HoodieSourceOffset = {
-    mapper.readValue[HoodieSourceOffset](json)
+    mapper.readValue(json, classOf[HoodieSourceOffset])

Review comment:
       is the change necessary?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1011989336


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785442866



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -26,7 +26,7 @@ import org.apache.spark.sql.execution.streaming.{Offset, SerializedOffset}
 
 case class HoodieSourceOffset(commitTime: String) extends Offset {
 
-  override def json(): String = {
+  override val json: String = {

Review comment:
       also the change is necessary? would you please clarify?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] boneanxs commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
boneanxs commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785450167



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -26,7 +26,7 @@ import org.apache.spark.sql.execution.streaming.{Offset, SerializedOffset}
 
 case class HoodieSourceOffset(commitTime: String) extends Offset {
 
-  override def json(): String = {
+  override val json: String = {

Review comment:
       This just is an improve change, json no need to recalculate when calling this again, as it's value can not be changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1011932160


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012846304


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5226",
       "triggerID" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5226) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] boneanxs commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
boneanxs commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012704948


   Hi, @xushiyan, can you review this fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1011929641


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012807071


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   * 0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012727423


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012693588


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] boneanxs commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
boneanxs commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785449928



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -45,17 +45,21 @@ case class HoodieSourceOffset(commitTime: String) extends Offset {
 
 
 object HoodieSourceOffset {
-  val mapper = new ObjectMapper with ScalaObjectMapper
-  mapper.setSerializationInclusion(Include.NON_ABSENT)
-  mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
-  mapper.registerModule(DefaultScalaModule)
+
+  lazy val mapper: ObjectMapper = {
+    val _mapper = new ObjectMapper
+    _mapper.setSerializationInclusion(Include.NON_ABSENT)
+    _mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+    _mapper.registerModule(DefaultScalaModule)
+    _mapper
+  }
 
   def toJson(offset: HoodieSourceOffset): String = {
     mapper.writeValueAsString(offset)
   }
 
   def fromJson(json: String): HoodieSourceOffset = {
-    mapper.readValue[HoodieSourceOffset](json)
+    mapper.readValue(json, classOf[HoodieSourceOffset])

Review comment:
       After remove `ScalaObjectMapper`, we need `ClassTag` to readValue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1011929641


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012695155


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012808196


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5226",
       "triggerID" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   * 0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5226) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1011932160


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] boneanxs commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
boneanxs commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785449636



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -45,17 +45,21 @@ case class HoodieSourceOffset(commitTime: String) extends Offset {
 
 
 object HoodieSourceOffset {
-  val mapper = new ObjectMapper with ScalaObjectMapper
-  mapper.setSerializationInclusion(Include.NON_ABSENT)
-  mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
-  mapper.registerModule(DefaultScalaModule)
+
+  lazy val mapper: ObjectMapper = {

Review comment:
       Yes, as `scalaObjectMapper` we can replaced with `ClassTag`, we can safely and simply solve the conflict issue with different scala version(2.11 and 2.12, etc)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012808196


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5226",
       "triggerID" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   * 0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5226) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785442552



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -45,17 +45,21 @@ case class HoodieSourceOffset(commitTime: String) extends Offset {
 
 
 object HoodieSourceOffset {
-  val mapper = new ObjectMapper with ScalaObjectMapper
-  mapper.setSerializationInclusion(Include.NON_ABSENT)
-  mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
-  mapper.registerModule(DefaultScalaModule)
+
+  lazy val mapper: ObjectMapper = {

Review comment:
       here we just need to remove the `with ScalaObjectMapper` in line#48 before?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785442620



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -45,17 +45,21 @@ case class HoodieSourceOffset(commitTime: String) extends Offset {
 
 
 object HoodieSourceOffset {
-  val mapper = new ObjectMapper with ScalaObjectMapper
-  mapper.setSerializationInclusion(Include.NON_ABSENT)
-  mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
-  mapper.registerModule(DefaultScalaModule)
+
+  lazy val mapper: ObjectMapper = {
+    val _mapper = new ObjectMapper
+    _mapper.setSerializationInclusion(Include.NON_ABSENT)
+    _mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+    _mapper.registerModule(DefaultScalaModule)
+    _mapper
+  }
 
   def toJson(offset: HoodieSourceOffset): String = {
     mapper.writeValueAsString(offset)
   }
 
   def fromJson(json: String): HoodieSourceOffset = {
-    mapper.readValue[HoodieSourceOffset](json)
+    mapper.readValue(json, classOf[HoodieSourceOffset])

Review comment:
       is the change necessary? I was thinking the meaning after the changing is same as before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf merged pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
leesf merged pull request #4586:
URL: https://github.com/apache/hudi/pull/4586


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012695155


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012693588


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] boneanxs commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
boneanxs commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1013797919


   @xushiyan @leesf @zhedoubushishi gentle ping...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1011989336


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0b078b0472dfdc47e221bfe8e440cc401b5100b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012807071


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   * 0d4cc106c5ae7d077a55a2dfab3ea13b6c9e2054 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#issuecomment-1012727423


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5189",
       "triggerID" : "a0b078b0472dfdc47e221bfe8e440cc401b5100b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212",
       "triggerID" : "2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2c2a5b8dadaaefce68b9d0730d6e18e8bcc0f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5212) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] boneanxs commented on a change in pull request #4586: [HUDI-1558] Struct Stream Source Support Spark3

Posted by GitBox <gi...@apache.org>.
boneanxs commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785449636



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -45,17 +45,21 @@ case class HoodieSourceOffset(commitTime: String) extends Offset {
 
 
 object HoodieSourceOffset {
-  val mapper = new ObjectMapper with ScalaObjectMapper
-  mapper.setSerializationInclusion(Include.NON_ABSENT)
-  mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
-  mapper.registerModule(DefaultScalaModule)
+
+  lazy val mapper: ObjectMapper = {

Review comment:
       Yes, as `scalaObjectMapper` we can replaced with `ClassTag`, we can safely and simply solve the conflict issue with different scala version(or Jackson-scala version to be more accurate)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org