You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hongtu Zang <ho...@tcloudcomputing.com> on 2013/02/05 03:31:47 UTC
Review Request: add ui for resize volume
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9298/
-----------------------------------------------------------
Review request for cloudstack, mice xia and Marcus Sorensen.
Description
-------
add ui for resizeVolume.
use updateResourceCount as icon of resizeVolume.
I don't know how to translate the label, so I use English in all files.
This addresses bug CLOUDSTACK-644.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties 390738f
client/WEB-INF/classes/resources/messages_fr_FR.properties 4ba3c72
client/WEB-INF/classes/resources/messages_ja.properties 7555b83
client/WEB-INF/classes/resources/messages_pt_BR.properties 3bc435b
client/WEB-INF/classes/resources/messages_ru_RU.properties dd7e746
client/WEB-INF/classes/resources/messages_zh_CN.properties 62160d9
ui/css/cloudstack3.css eb42843
ui/dictionary.jsp 203c9da
ui/scripts/storage.js dd81378
Diff: https://reviews.apache.org/r/9298/diff/
Testing
-------
Input newSize and newOfferingId.
The api will be sent and returns correct.
NewSize should be GB and newOfferingId find in database, not the uuid.
Thanks,
Hongtu Zang
Re: Review Request: add ui for resize volume
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9298/#review16079
-----------------------------------------------------------
is it better if we list diskoffering with a dropdown list, and show the disk size input field when users choose 'custom disk offering', just like the 'create volume' dialog?
- mice xia
On Feb. 5, 2013, 2:31 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9298/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 2:31 a.m.)
>
>
> Review request for cloudstack, mice xia and Marcus Sorensen.
>
>
> Description
> -------
>
> add ui for resizeVolume.
> use updateResourceCount as icon of resizeVolume.
> I don't know how to translate the label, so I use English in all files.
>
>
> This addresses bug CLOUDSTACK-644.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 390738f
> client/WEB-INF/classes/resources/messages_fr_FR.properties 4ba3c72
> client/WEB-INF/classes/resources/messages_ja.properties 7555b83
> client/WEB-INF/classes/resources/messages_pt_BR.properties 3bc435b
> client/WEB-INF/classes/resources/messages_ru_RU.properties dd7e746
> client/WEB-INF/classes/resources/messages_zh_CN.properties 62160d9
> ui/css/cloudstack3.css eb42843
> ui/dictionary.jsp 203c9da
> ui/scripts/storage.js dd81378
>
> Diff: https://reviews.apache.org/r/9298/diff/
>
>
> Testing
> -------
>
> Input newSize and newOfferingId.
> The api will be sent and returns correct.
> NewSize should be GB and newOfferingId find in database, not the uuid.
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: add ui for resize volume
Posted by Marcus Sorensen <sh...@gmail.com>.
You can close the review, it's been applied.
On Tue, Feb 5, 2013 at 12:05 PM, Marcus Sorensen <sh...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9298/
>
> Ship it!
>
> Ship It!
>
>
> - Marcus
>
> On February 5th, 2013, 5:08 a.m., Hongtu Zang wrote:
> Review request for cloudstack, mice xia and Marcus Sorensen.
> By Hongtu Zang.
>
> *Updated Feb. 5, 2013, 5:08 a.m.*
> Description
>
> add ui for resizeVolume.
> use updateResourceCount as icon of resizeVolume.
> I don't know how to translate the label, so I use English in all files.
>
> Testing
>
> Input newSize and newOfferingId.
> The api will be sent and returns correct.
> NewSize should be GB and newOfferingId find in database, not the uuid.
>
> *Bugs: * CLOUDSTACK-644
> Diffs
>
> - client/WEB-INF/classes/resources/messages.properties (390738f)
> - client/WEB-INF/classes/resources/messages_fr_FR.properties (4ba3c72)
> - client/WEB-INF/classes/resources/messages_ja.properties (7555b83)
> - client/WEB-INF/classes/resources/messages_pt_BR.properties (3bc435b)
> - client/WEB-INF/classes/resources/messages_ru_RU.properties (dd7e746)
> - client/WEB-INF/classes/resources/messages_zh_CN.properties (62160d9)
> - ui/css/cloudstack3.css (eb42843)
> - ui/dictionary.jsp (203c9da)
> - ui/scripts/storage.js (dd81378)
>
> View Diff <https://reviews.apache.org/r/9298/diff/>
>
Re: Review Request: add ui for resize volume
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9298/#review16131
-----------------------------------------------------------
Ship it!
Ship It!
- Marcus Sorensen
On Feb. 5, 2013, 5:08 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9298/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:08 a.m.)
>
>
> Review request for cloudstack, mice xia and Marcus Sorensen.
>
>
> Description
> -------
>
> add ui for resizeVolume.
> use updateResourceCount as icon of resizeVolume.
> I don't know how to translate the label, so I use English in all files.
>
>
> This addresses bug CLOUDSTACK-644.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 390738f
> client/WEB-INF/classes/resources/messages_fr_FR.properties 4ba3c72
> client/WEB-INF/classes/resources/messages_ja.properties 7555b83
> client/WEB-INF/classes/resources/messages_pt_BR.properties 3bc435b
> client/WEB-INF/classes/resources/messages_ru_RU.properties dd7e746
> client/WEB-INF/classes/resources/messages_zh_CN.properties 62160d9
> ui/css/cloudstack3.css eb42843
> ui/dictionary.jsp 203c9da
> ui/scripts/storage.js dd81378
>
> Diff: https://reviews.apache.org/r/9298/diff/
>
>
> Testing
> -------
>
> Input newSize and newOfferingId.
> The api will be sent and returns correct.
> NewSize should be GB and newOfferingId find in database, not the uuid.
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: add ui for resize volume
Posted by Hongtu Zang <ho...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9298/
-----------------------------------------------------------
(Updated Feb. 5, 2013, 5:08 a.m.)
Review request for cloudstack, mice xia and Marcus Sorensen.
Changes
-------
a good advice, I didn't think about it before.
I changed diskoffering to a dropdown list, like the 'create volume' dialog.
Description
-------
add ui for resizeVolume.
use updateResourceCount as icon of resizeVolume.
I don't know how to translate the label, so I use English in all files.
This addresses bug CLOUDSTACK-644.
Diffs (updated)
-----
client/WEB-INF/classes/resources/messages.properties 390738f
client/WEB-INF/classes/resources/messages_fr_FR.properties 4ba3c72
client/WEB-INF/classes/resources/messages_ja.properties 7555b83
client/WEB-INF/classes/resources/messages_pt_BR.properties 3bc435b
client/WEB-INF/classes/resources/messages_ru_RU.properties dd7e746
client/WEB-INF/classes/resources/messages_zh_CN.properties 62160d9
ui/css/cloudstack3.css eb42843
ui/dictionary.jsp 203c9da
ui/scripts/storage.js dd81378
Diff: https://reviews.apache.org/r/9298/diff/
Testing
-------
Input newSize and newOfferingId.
The api will be sent and returns correct.
NewSize should be GB and newOfferingId find in database, not the uuid.
Thanks,
Hongtu Zang