You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/02 16:53:57 UTC

[GitHub] rabbah closed pull request #2: Typo: PHP does not include the letters s, w, i, f, or t

rabbah closed pull request #2: Typo: PHP does not include the letters s, w, i, f, or t
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 8081299..9c7aea5 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-# Apache OpenWhisk runtimes for swift
+# Apache OpenWhisk runtimes for PHP
 [![Build Status](https://travis-ci.org/apache/incubator-openwhisk-runtime-php.svg?branch=master)](https://travis-ci.org/apache/incubator-openwhisk-runtime-php)
 
 
@@ -17,14 +17,14 @@ wsk action update myAction myAction.php --kind php:7.1
 
 ### Local development
 ```
-./gradlew core:swiftAction:distDocker
+./gradlew core:php7.1Action:distDocker
 ```
 This will produce the image `whisk/action-php-v7.1`
 
 Build and Push image
 ```
 docker login
-./gradlew core:swiftAction:distDocker -PdockerImagePrefix=$prefix-user -PdockerRegistry=docker.io 
+./gradlew core:php7.1Action:distDocker -PdockerImagePrefix=$prefix-user -PdockerRegistry=docker.io
 ```
 
 Deploy OpenWhisk using ansible environment that contains the kind `php:7.1`
@@ -45,13 +45,13 @@ $ANSIBLE_CMD openwhisk.yml
 
 Or you can use `wskdev` and create a soft link to the target ansible environment, for example:
 ```
-ln -s ${ROOTDIR}/ansible/environments/local ${OPENWHISK_HOME}/ansible/environments/local-swift
-wskdev fresh -t local-swift
+ln -s ${ROOTDIR}/ansible/environments/local ${OPENWHISK_HOME}/ansible/environments/local-php
+wskdev fresh -t local-php
 ```
 
 To use as docker action push to your own dockerhub account
 ```
-docker tag whisk/swift8action $user_prefix/action-php-v7.1
+docker tag whisk/php7.1Action $user_prefix/action-php-v7.1
 docker push $user_prefix/action-php-v7.1
 ```
 Then create the action using your the image from dockerhub
diff --git a/ansible/environments/local/hosts b/ansible/environments/local/hosts
index c99f195..6a7f5d5 100644
--- a/ansible/environments/local/hosts
+++ b/ansible/environments/local/hosts
@@ -9,9 +9,12 @@ ansible ansible_connection=local
 [controllers]
 controller0         ansible_host=172.17.0.1 ansible_connection=local
 
-[kafka]
+[kafkas]
 172.17.0.1          ansible_host=172.17.0.1 ansible_connection=local
 
+[zookeepers:children]
+kafkas
+
 [invokers]
 invoker0            ansible_host=172.17.0.1 ansible_connection=local
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services