You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2012/05/14 07:19:54 UTC
[jira] [Created] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
ramkrishna.s.vasudevan created HBASE-5997:
---------------------------------------------
Summary: Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
Key: HBASE-5997
URL: https://issues.apache.org/jira/browse/HBASE-5997
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Pls refer to the comment
https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Attachment: 5997v3_trunk.txt
Retrying v3 against hadoopqa
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John reassigned HBASE-5997:
-------------------------------------
Assignee: Anoop Sam John
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5997:
----------------------------------
Affects Version/s: 0.96.0
0.90.6
0.92.1
0.94.0
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278016#comment-13278016 ]
Zhihong Yu commented on HBASE-5997:
-----------------------------------
@Anoop:
Good analysis.
Can you put the scenario described @ 17/May/12 10:09 into a test ?
Then it is easier to validate your proposal above.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442947#comment-13442947 ]
Hadoop QA commented on HBASE-5997:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542718/5997v3_trunk.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 106 warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.TestLocalHBaseCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2713//console
This message is automatically generated.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5997:
----------------------------------
Attachment: HBASE-5997_0.94.patch
Patch for 0.94 version
Now I have changed like the check will compare the rowkey only. From the external usage of this API within HBase code, we always do the seekBefore based on rowkey only. Not with rowkey+cf+qualifier way.
Pls provide your suggestion
Once the solution is ok I can backport for other versions.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Status: Patch Available (was: Open)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409952#comment-13409952 ]
Lars Hofhansl commented on HBASE-5997:
--------------------------------------
BTW. HTableInterface.getRowOrBefore is deprecated. Nobody should be using that.
Are the issues you address here seen during our particular internal meta lookups (which are special cases)?
(It's time to fix HBASE-2600)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Attachment: 5997v3_trunk.txt
Retry
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412814#comment-13412814 ]
stack commented on HBASE-5997:
------------------------------
On the first item, won't that be a seek each time we go for the firstKey in an empty file? It will be rare yes, but could be a pain if happened so would suggest a boolean flag for whether or not we've done the first key check.
On the second item when we do the compare, are the offsets to where the key bytes start or to where the key starts (with its length preample)? For sure, we are comparing the row portions of keys?
Thanks Anoop.
(@Lars Maybe its ok putting this into 0.94.2 or into second 0.94.1RC).
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Resolution: Fixed
Fix Version/s: (was: 0.94.3)
Status: Resolved (was: Patch Available)
Committed to trunk. I think its fine being in trunk only. Speak up Lars if you want it on 0.94.
Thanks for the patch Anoop. Good digging.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469894#comment-13469894 ]
Hudson commented on HBASE-5997:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #8 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/8/])
HBASE-5997 Fix concerns raised in HBASE-5922 related to HalfStoreFileReader (Revision 1383792)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2, 0.96.0
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452796#comment-13452796 ]
Hadoop QA commented on HBASE-5997:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544599/5997v3_trunk.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause mvn compile goal to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
org.apache.hadoop.hbase.client.TestFromClientSide
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2847//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2847//console
This message is automatically generated.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284125#comment-13284125 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
@Stack, @Ted Can u people have a look at the patch pls?
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278136#comment-13278136 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
Actually there is another issue with the HTable.getRowOrBefore() API I think... Not with this half store file reading..
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412480#comment-13412480 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
bq. Is it possible if the file is empty say that we'll seek on every invocation of getFirstKey?
Yes as the check is against firstKey being not null. May be we can have a boolean variable based check.
As this is rare chance and the existance of the half file also wont be for more time( normally) I thought may be okey. What do u say Stack? If you feel I can change this.
bq.This patch does not do you your compare of row only rather than compare of full key. Is it supposed to?
Yes. You can see that the comparison now is against the first key in the file rather than the split key
{code}
- if (getComparator().compare(key, offset, length, splitkey, 0,
- splitkey.length) < 0) {
+ byte[] fk = getFirstKey();
+ // This will be null when the file is empty in which we can not seekBefore to any key
+ if (fk == null) return false;
+ if (getComparator().compare(key, offset, length, fk, 0,
+ fk.length) <= 0) {
{code}
So it is okey to have the full key based compare.[Not rowkey alone]
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453795#comment-13453795 ]
Hudson commented on HBASE-5997:
-------------------------------
Integrated in HBase-TRUNK #3322 (See [https://builds.apache.org/job/HBase-TRUNK/3322/])
HBASE-5997 Fix concerns raised in HBASE-5922 related to HalfStoreFileReader (Revision 1383788)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455028#comment-13455028 ]
Hudson commented on HBASE-5997:
-------------------------------
Integrated in HBase-0.94-security #52 (See [https://builds.apache.org/job/HBase-0.94-security/52/])
HBASE-5997 Fix concerns raised in HBASE-5922 related to HalfStoreFileReader (Revision 1383792)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Attachment: 5997v3_trunk.txt
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5997:
---------------------------------
Fix Version/s: 0.94.1
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277700#comment-13277700 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
Was able to produce one issue
Have one table with a region [r1-r5). Now split this region with splitkey as r3
The two regions will be [r1-r3) and [r3-r5)
Now call HTable.getRowOrBefore() with passing row as r3 (splitkey)
Mean while there is no data with rowkey as r3 in the table
The above call will create a seekBefore on the top half file with key as r3 and currently it will seek into the bottom file and gets the last KV in that file.
After getting the KV in the HRegion.getClosestRowBefore(), there is a Get call to fetch the KV. This Get will fail in 1st step itself as the rowkey it is trying to fetch is not in range of [r3,r5).. So in my scenario the call is throwing Exception
WrongRegionException("Requested row out of range for......")
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Status: Open (was: Patch Available)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410776#comment-13410776 ]
Lars Hofhansl commented on HBASE-5997:
--------------------------------------
Ah yes, so we can move this to 0.94.2 then, I think. Agreed?
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Status: Patch Available (was: Open)
Retrying Anoops patch since it was another issue hanging tests.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453806#comment-13453806 ]
Hudson commented on HBASE-5997:
-------------------------------
Integrated in HBase-0.94 #464 (See [https://builds.apache.org/job/HBase-0.94/464/])
HBASE-5997 Fix concerns raised in HBASE-5922 related to HalfStoreFileReader (Revision 1383792)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Status: Open (was: Patch Available)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452760#comment-13452760 ]
stack commented on HBASE-5997:
------------------------------
@Anoop How dare you go on vacation! (smile). Retrying the patch against hadoopqa... if passes will commit.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411227#comment-13411227 ]
Lars Hofhansl commented on HBASE-5997:
--------------------------------------
Heh, Stack and I were saying it's fine for 0.94.1 :)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5997:
----------------------------------
Attachment: HBASE-5997_94 V2.patch
Patch addressing the issues I mentioned above. The attached test case wont throw Exception now. But this return null.. This issue I already commented above. We will try to address the same in another JIRA.
[The API will only work with one region, if no apt data found there it will just return null to the user. But IMO it should go its previous region and get the data]
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410272#comment-13410272 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
bq.Are the issues you address here seen during our particular internal meta lookups (which are special cases)?
No. META table will have only one region which will not get split.(As of now)
This issue was raised as a followup for HBASE-5922. This was reported as real use case issue. That issue was with bottom half store.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442948#comment-13442948 ]
stack commented on HBASE-5997:
------------------------------
So, it looks like this patch doesn't hang tests (that maybe it hbase-6477). OK I add this to trunk and 0.94 (even though I'd thought I'd done 0.94 last time)?
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Status: Patch Available (was: Open)
Try against hadoopqa again. Uses deprecated API but nothing yet that can be used in its stead (can work on this when we remove the deprecated API).
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278994#comment-13278994 ]
Zhihong Yu commented on HBASE-5997:
-----------------------------------
@Anoop:
Is your patch supposed to fix the problem shown in the unit test published yesterday ?
With the patch, I still see the following test failure:
{code}
testHalfScannerSeekBefore(org.apache.hadoop.hbase.io.TestHBASE5997) Time elapsed: 3.193 sec <<< ERROR!
org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=1, exceptions:
Fri May 18 10:31:13 PDT 2012, org.apache.hadoop.hbase.client.HTable$4@605df3c5, org.apache.hadoop.hbase.regionserver.WrongRegionException: org.apache.hadoop.hbase.regionserver.WrongRegionException: Requested row out of range for Get on HRegion t1,r3,1337362272730.9f3ae0ff1963c95df2df0aa768e739fc., startKey='r3', getEndKey()='', row='r2'
{code}
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413884#comment-13413884 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
bq. On the second item when we do the compare, are the offsets to where the key bytes start or to where the key starts (with its length preample)? For sure, we are comparing the row portions of keys?
Offset will be to the key(with its length preample). KeyComparator will be used.we can see how the rowLength being considered. We compare the full key (rowKey and then CF, qualifier... )
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278140#comment-13278140 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
Sorry could not complete the typing and by mistake pressed submit :(
Continuation of the above comment
As per the documentation of this API
{code}
* Return the row that matches <i>row</i> exactly,
* or the one that immediately precedes it.
{code}
If there are 2 regions in a table [r1,r3) and [r3,r5)
When this API is called with row as r3, The client will select the second region. And suppose there is no KV in this region with rowkey as r3. So the return from this region will be null... But still as a user I would expect the call to return highest row from the 1st region. Say there we have row with key r2...
Still this API will not do that and will return null
This same kind of handling might be needed when we have more than one region in the META table also...
Hope I am making it clear
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442863#comment-13442863 ]
Hadoop QA commented on HBASE-5997:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542687/5997v3_trunk.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 94 warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.security.access.TestAccessController
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2709//console
This message is automatically generated.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411221#comment-13411221 ]
ramkrishna.s.vasudevan commented on HBASE-5997:
-----------------------------------------------
+1 on committing. Thanks to Anoop for the nice finding.
Thanks Stack and Lars.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453737#comment-13453737 ]
stack commented on HBASE-5997:
------------------------------
Oh, I ran the tests that failed in the above locally and all passed.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452704#comment-13452704 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
@Stack - Sorry I was out of work for some time. So this patch does not make the test case to hang right? Pls let me know whether I need to check some thing.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453915#comment-13453915 ]
Hudson commented on HBASE-5997:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #169 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/169/])
HBASE-5997 Fix concerns raised in HBASE-5922 related to HalfStoreFileReader (Revision 1383788)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278131#comment-13278131 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
the table.getRowOrBefore("r3".getBytes(), FAMILY); will reach the region [r3,) and so to the half store file but will seek and into bottom..
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5997:
----------------------------------
Attachment: Testcase.patch.txt
Includes the test case which reproduces the issue which I was mentioning..seekBefore() on top half file seeks into the bottom half.
I am getting the below exception
{code}
org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=1, exceptions:
Fri May 18 00:44:07 IST 2012, org.apache.hadoop.hbase.client.HTable$4@619130e2, org.apache.hadoop.hbase.regionserver.WrongRegionException: org.apache.hadoop.hbase.regionserver.WrongRegionException: Requested row out of range for Get on HRegion t1,r3,1337282045838.51accaef959568917250932a1863f4fe., startKey='r3', getEndKey()='', row='r2'
at org.apache.hadoop.hbase.client.ServerCallable.withRetries(ServerCallable.java:183)
at org.apache.hadoop.hbase.client.HTable.getRowOrBefore(HTable.java:644)
at org.apache.hadoop.hbase.io.TestHBASE5997.testHalfScannerSeekBefore(TestHBASE5997.java:93)
{code}
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442218#comment-13442218 ]
Ted Yu commented on HBASE-5997:
-------------------------------
Hit HBASE-6667 in the test run
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442208#comment-13442208 ]
Ted Yu commented on HBASE-5997:
-------------------------------
Since I got some finding w.r.t. HBASE-6477, I am rerunning test suite without patch for 6477 but with trunk patch for this JIRA.
Will report back whether the build passes.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Status: Open (was: Patch Available)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411082#comment-13411082 ]
Lars Hofhansl commented on HBASE-5997:
--------------------------------------
@Stack: Completely agree. I'm good on committing.
@Anoop: Can you briefly address Stack's questions above? After that I'll check it in. Thanks for all the work on this!
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411225#comment-13411225 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
@Lars
I am okey for 94.2
Yes I will address Stacks comments. [Was bit busy with some other works:(]
@Stack
Thanks a lot for your review.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442986#comment-13442986 ]
ramkrishna.s.vasudevan commented on HBASE-5997:
-----------------------------------------------
@Stack/@Ted
Do let me know if you want me to check on this. Anoop is on vacation . Our internal CI which runs on 0.94 does not report any error and it is running fine for quite a few days.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281485#comment-13281485 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
I have gone through the flow for this API. I think there are some issues
1. In Store.rowAtOrBeforeFromStoreFile()
Gets StoreFile.Reader.getFirstKey()
In case of the half store file, this reader just calls the actual file reader. But this will give the 1st key in the physical HFile(which is the 1st key in the bottom half file also). The getFirstKey() is not overriden in the HalfStoreFileReader.
2. In Store.rowAtOrBeforeFromStoreFile() itself
HFileScanner scanner = r.getHFileReader().getScanner(true, true, false);
In case of the half file, r will be the HalfStoreFileReader instance. But as we dont call getScanner() on "r", always it will get the actual HFileScanner for the HFile( The delegator in the HFileScanner instance in HalfStoreFileReader ).
3. Other than these 2 issues we need to correct the issue with the seekBefore() API in the HalfStoreFileReader.getScanner
I will address these issues and give a patch in some time.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-5997:
--------------------------
Status: Patch Available (was: Reopened)
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442226#comment-13442226 ]
Hudson commented on HBASE-5997:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #150 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/150/])
HBASE-5997 Fix concerns raised in HBASE-5922 related to HalfStoreFileReader; REVERT (Revision 1377483)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.3
>
> Attachments: 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278605#comment-13278605 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
Whatever issue I was mentioning above, we can make out of this JIRA. So will focus on the HalfStoreFileReader issue here.. Will deal the other with another JIRA issue.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410915#comment-13410915 ]
stack commented on HBASE-5997:
------------------------------
@Lars I think you should commit it just because of the amount of sweat Anoop expended here. Those two findings of his are pretty cool, pretty fancy detective work (The call is deprecated but still pivotal right until we do the replacement?). Just an opinion. Yeah, could go to 0.94.2.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277704#comment-13277704 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
As I mentioned there are 2 issues
1. We need to change the if check such that return false when the passed key is equal to the splitkey also. Because in the file there wont be any KV with rowkey less than the splitkey. That will be obviously in the bottom half.
2. In the comparator we pass the passed key as the left item and the split key byte[] as the right item. The split key always byte[] will contains
rowkeylenth + rowkey. There wont be any bytes corresponding to CF name or qualifier name or the timestamp bytes. So when the passed key is with rowkey=splitkey and contains any bytes corresponding to any of these items ( well this is key of KV and contain any ) the comparator will return a value >0
Calls getting to this API from HBase code pass only rowkey(rowkeylenth + rowkey) and a timestamp [timestamp=HConstants.LATEST_TIMESTAMP] But no CF name and qualifier name. So if the top file contains KVs with rowkey as splitkey still all those KVs will look as greater than the passed key as every KV will contain the CF name bytes after the rowkey bytes. So always it will seek into the bottom half.
Can we take only the part of the byte[] passed to this method ( seekBefore)? We need to take only the bytes rowkeylenth + rowkey
like below
{code}
- if (getComparator().compare(key, offset, length, splitkey, 0,
- splitkey.length) < 0) {
+ short lrowlength = Bytes.toShort(key, offset);
+ if (getComparator().compare(key, offset, lrowlength, splitkey, 0,
+ splitkey.length) <= 0) {
{code}
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5997:
----------------------------------
Attachment: HBASE-5997_94 V3.patch
Patch addressing Stack's comment
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278135#comment-13278135 ]
stack commented on HBASE-5997:
------------------------------
@Anoop Excellent work.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-5997:
----------------------------------
Fix Version/s: (was: 0.94.1)
0.94.2
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.2
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280692#comment-13280692 ]
Anoop Sam John commented on HBASE-5997:
---------------------------------------
The patch was addressing the issue with that API alone.
Sorry I could not run that E2E test case. I was out of work for some days.
I have looked into the E2E flow of the getRowOrBefore() in case of ref files being present for the regions.. Seems some other issues also... Will work on this and come up with the analysis and patch soon.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Attachments: HBASE-5997_0.94.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291633#comment-13291633 ]
ramkrishna.s.vasudevan commented on HBASE-5997:
-----------------------------------------------
@Stack
Can have a look at this?May be needed in the RCs that we will be taking either for 0.94 or 0.92.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453755#comment-13453755 ]
Lars Hofhansl commented on HBASE-5997:
--------------------------------------
Well... If you ask this way... Let's have it in 0.94 as well. So that this logic is correct.
getRowOrBefore is deprecated, but it is still there, and folks can use it.
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5997:
-------------------------
Fix Version/s: 0.94.2
Committed to 0.94 toooooo
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, 5997v3_trunk.txt, HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, HBASE-5997_94 V3.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
related to HalfStoreFileReader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409794#comment-13409794 ]
stack commented on HBASE-5997:
------------------------------
@Anoop Great work. Agree on the seekBefore finding. Lets fix that in another issue.
On the patch, minor comment only (I'm good w/ commit):
{code}
if (firstKey == null) {
{code}
Is it possible if the file is empty say that we'll seek on every invocation of getFirstKey?
This patch does not do you your compare of row only rather than compare of full key. Is it supposed to?
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
> Key: HBASE-5997
> URL: https://issues.apache.org/jira/browse/HBASE-5997
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira