[GitHub] [airflow] olchas commented on a change in pull request #8477: Refactor BigQueryHook dataset operations

[GitBox <gi...@apache.org>]

olchas commented on a change in pull request #8477:
URL: https://github.com/apache/airflow/pull/8477#discussion_r415879472



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1301,8 +1302,8 @@ class BigQueryUpdateDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(self,
-                 dataset_id: str,
                  dataset_resource: dict,
+                 dataset_id: Optional[str] = None,

Review comment:
       This change in order of arguments probably needs a note in UPDATING.md as well

##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -2093,7 +2089,7 @@ def create_empty_dataset(self, *args, **kwargs) -> None:
             DeprecationWarning, stacklevel=3)
         return self.hook.create_empty_dataset(*args, **kwargs)
 
-    def get_dataset_tables(self, *args, **kwargs) -> Dict[str, Union[str, int, List]]:
+    def get_dataset_tables(self, *args, **kwargs) -> List[Dict[str, Any]]:

Review comment:
       Should change of returned type in these deprecated methods (`get_dataset_tables` and `get_dataset_tables_list`) be reflected in UPDATING.md as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org