[GitHub] [incubator-hugegraph-computer] Radeity commented on a diff in pull request #259: feat: init operator project & add webhook

["Radeity (via GitHub)" <gi...@apache.org>]

Radeity commented on code in PR #259:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/259#discussion_r1263320223


##########
computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/crd/model/HugeGraphComputerJob.java:
##########
@@ -40,7 +40,7 @@ public class HugeGraphComputerJob
     private static final long serialVersionUID = 6788317713035067450L;
 
     public static final String VERSION = "v1";
-    public static final String GROUP = "hugegraph.apache.org";
+    public static final String GROUP = "operator.hugegraph.apache.org";

Review Comment:
   Hi @coderzc , group name is combination of `group` and `domain`.
   https://github.com/apache/incubator-hugegraph-computer/blob/6acca992a803f1cff53d0c0e129fc2e64e7c74f0/computer-k8s-operator/crd-generate/PROJECT#L32-L33
   I have referred to some other projects, we should better keep the domain `hugegraph.apache.org` and set `group` like `operator`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org