You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/22 21:14:10 UTC
[GitHub] [netbeans] nbauma109 opened a new pull request, #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
nbauma109 opened a new pull request, #4273:
URL: https://github.com/apache/netbeans/pull/4273
After JDK8, the Instrumentation interface introduced 2 methods isModifiableModule and redefineModule having Module class in their signature. NbInstrumentation implemented the newer version of Instrumentation interface using Module, which was incompatible with JDK8. The compatibility was ensured by an empty class Module which causes package conflict with the JDK. I propose to remove that and have a dynamic proxy that will handle all versions of Instrumentation interface thanks to an invocation handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4273:
URL: https://github.com/apache/netbeans/pull/4273#issuecomment-1165899835
can't get one of the commit validation jobs green (see #4211) and the build artifact is going to expire soon. I believe we can ignore that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4273:
URL: https://github.com/apache/netbeans/pull/4273#issuecomment-1165903787
Ignore it - I restarted the Travis tests, as they more or less all failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4273:
URL: https://github.com/apache/netbeans/pull/4273#issuecomment-1166258867
Travis is happy. I had a quick look at this and it looks sane to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #4273:
URL: https://github.com/apache/netbeans/pull/4273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] nbauma109 commented on pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
nbauma109 commented on PR #4273:
URL: https://github.com/apache/netbeans/pull/4273#issuecomment-1164790736
Just noticed I forgot to throw UnsupportedOperationException. Just pushed the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on PR #4273:
URL: https://github.com/apache/netbeans/pull/4273#issuecomment-1177208681
Nice rewrite. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4273: Issue 4243: delete java/lang/Module and use dynamic proxy to implement Instrumentation across JDK versions…
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4273:
URL: https://github.com/apache/netbeans/pull/4273#issuecomment-1176545210
The code looks sane, there are unittests, that hit the modified codepaths and still work, lets get this in.
For the record @nbauma109 I assume you read the license header and you are aware, that your contribution is under the assumption that you donate the code to the ASF. Thank you for your work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists