You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (Updated) (JIRA)" <ji...@apache.org> on 2012/02/14 22:59:59 UTC
[jira] [Updated] (SOLR-2847) fix test bug in
DistributedSpellCheckComponentTest
[ https://issues.apache.org/jira/browse/SOLR-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-2847:
-----------------------------
Attachment: SOLR-2847.patch
updated patch fixes devious test bug. With this patch, if the "controlData" doesn't return any spellcheck responses, the test fails.
Will commit soon & port to 3x. Figure this is a good practice-commit for me.
> fix test bug in DistributedSpellCheckComponentTest
> --------------------------------------------------
>
> Key: SOLR-2847
> URL: https://issues.apache.org/jira/browse/SOLR-2847
> Project: Solr
> Issue Type: Bug
> Components: multicore, spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 4.0
>
> Attachments: SOLR-2847.patch, SOLR-2847.patch
>
>
> In Trunk, the IndexBasedSpellChecker dictionary is not being built both for the "control" and "shard" indexes. The test then compares nothing to nothing and passes, because both the shard-index response and the control-index responses are the same. This issue fixes the problem with the dictionaries not being built and also adds an additional check for data in the control-index responses so that this sort of regression may be detected in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org