You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Gergo Barna <bp...@gmail.com> on 2018/04/27 14:10:06 UTC
Review Request 66851: NPE in Atlas Hive2 hook when creating views
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66851/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-2611
https://issues.apache.org/jira/browse/ATLAS-2611
Repository: atlas
Description
-------
NPE in Atlas Hive2 hook when creating views
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 43016d4
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java dc14480
Diff: https://reviews.apache.org/r/66851/diff/1/
Testing
-------
Thanks,
Gergo Barna
Re: Review Request 66851: NPE in Atlas Hive2 hook when creating views
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66851/#review202064
-----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
Line 139 (original), 149 (patched)
<https://reviews.apache.org/r/66851/#comment283717>
Instead of bringing back ColumnLineageUtils.java from test to product, consider moving only ColumnLineageUtils.getBaseCols() method here and replace line #149 as below:
for (BaseColumnInfo baseColumn : ColumnLineageUtils.getBaseCols(entry.getValue())) {
- Madhan Neethiraj
On April 27, 2018, 2:10 p.m., Gergo Barna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66851/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 2:10 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2611
> https://issues.apache.org/jira/browse/ATLAS-2611
>
>
> Repository: atlas
>
>
> Description
> -------
>
> NPE in Atlas Hive2 hook when creating views
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 43016d4
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java dc14480
>
>
> Diff: https://reviews.apache.org/r/66851/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gergo Barna
>
>