[GitHub] [druid] jihoonson commented on a change in pull request #8909: Optimize CachingLocalSegmentAllocator#getSequenceName

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #8909: Optimize CachingLocalSegmentAllocator#getSequenceName
URL: https://github.com/apache/druid/pull/8909#discussion_r362688240
 
 

 ##########
 File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/RangePartitionCachingLocalSegmentAllocatorTest.java
 ##########
 @@ -141,6 +142,16 @@ public void allocatesCorrectShardSpecsForLastPartition()
     testAllocate(row, interval, partitionNum, null);
   }
 
+  @Test
+  public void test_getSequenceName_forIntervalAndRow_shouldUseISOFormatAndPartitionNumForRow()
 
 Review comment:
   Sorry for late reply. You can start a discussion by starting a new thread on dev which is you already did (thanks!). There's no approval or veto in this kind of discussion. Anyone can participate in the discussion and express their opinion. The discussion could be concluded when the community accepts it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org