You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemml.apache.org by mb...@apache.org on 2018/07/17 23:47:46 UTC
systemml git commit: [HOTFIX] Fix javadoc and logging issues
dmloptions and codegen
Repository: systemml
Updated Branches:
refs/heads/master aed46e3b5 -> 7f54592fe
[HOTFIX] Fix javadoc and logging issues dmloptions and codegen
Project: http://git-wip-us.apache.org/repos/asf/systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/systemml/commit/7f54592f
Tree: http://git-wip-us.apache.org/repos/asf/systemml/tree/7f54592f
Diff: http://git-wip-us.apache.org/repos/asf/systemml/diff/7f54592f
Branch: refs/heads/master
Commit: 7f54592feda197d80752ec1b1b5d2054bef8d952
Parents: aed46e3
Author: Matthias Boehm <mb...@gmail.com>
Authored: Tue Jul 17 16:49:00 2018 -0700
Committer: Matthias Boehm <mb...@gmail.com>
Committed: Tue Jul 17 16:49:00 2018 -0700
----------------------------------------------------------------------
src/main/java/org/apache/sysml/api/DMLOptions.java | 14 ++------------
.../org/apache/sysml/hops/codegen/SpoofCompiler.java | 2 +-
2 files changed, 3 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/systemml/blob/7f54592f/src/main/java/org/apache/sysml/api/DMLOptions.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/api/DMLOptions.java b/src/main/java/org/apache/sysml/api/DMLOptions.java
index 1f0f45a..2cb147a 100644
--- a/src/main/java/org/apache/sysml/api/DMLOptions.java
+++ b/src/main/java/org/apache/sysml/api/DMLOptions.java
@@ -87,12 +87,10 @@ public class DMLOptions {
'}';
}
-
/**
* Parses command line arguments to create a {@link DMLOptions} instance with the correct options
- * @param args arguments from the command line
- * @param options an {@link Options} instance containing the options that need to be parsed
- * @return an instance of {@link Options} that contain the correct {@link Option}s.
+ * @param args arguments from the command line
+ * @return an instance of {@link DMLOptions} that contain the correct {@link Option}s.
* @throws org.apache.commons.cli.ParseException if there is an incorrect option specified in the CLI
*/
public static DMLOptions parseCLArguments(String[] args)
@@ -198,14 +196,6 @@ public class DMLOptions {
return dmlOptions;
}
- /**
- * Creates an {@link Options} instance for the command line parameters
- * As of SystemML 0.13, Apache Commons CLI 1.2 is transitively in the classpath
- * However the most recent version of Apache Commons CLI is 1.4
- * Creating CLI options is done using Static methods. Instead of {@link OptionBuilder},
- * CLI 1.4 uses Option.Builder which has non-static methods.
- * @return an appropriate instance of {@link Options}
- */
@SuppressWarnings("static-access")
private static Options createCLIOptions() {
Options options = new Options();
http://git-wip-us.apache.org/repos/asf/systemml/blob/7f54592f/src/main/java/org/apache/sysml/hops/codegen/SpoofCompiler.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/hops/codegen/SpoofCompiler.java b/src/main/java/org/apache/sysml/hops/codegen/SpoofCompiler.java
index 8302eca..fd012ec 100644
--- a/src/main/java/org/apache/sysml/hops/codegen/SpoofCompiler.java
+++ b/src/main/java/org/apache/sysml/hops/codegen/SpoofCompiler.java
@@ -102,7 +102,7 @@ public class SpoofCompiler
private static final Log LOG = LogFactory.getLog(SpoofCompiler.class.getName());
//internal configuration flags
- public static final boolean LDEBUG = true;
+ public static final boolean LDEBUG = false;
public static CompilerType JAVA_COMPILER = CompilerType.JANINO;
public static PlanSelector PLAN_SEL_POLICY = PlanSelector.FUSE_COST_BASED_V2;
public static final IntegrationType INTEGRATION = IntegrationType.RUNTIME;