You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/24 23:12:59 UTC
[GitHub] [beam] robertwb opened a new pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
robertwb opened a new pull request #11521:
URL: https://github.com/apache/beam/pull/11521
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a change in pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #11521:
URL: https://github.com/apache/beam/pull/11521#discussion_r421880710
##########
File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -613,7 +620,7 @@ public synchronized void close() {
// These will be closed in the reverse creation order:
try (AutoCloseable envCloser = environment;
AutoCloseable provisioningServer = serverInfo.getProvisioningServer();
- AutoCloseable retrievalServer = serverInfo.getRetrievalServer();
+ AutoCloseable retrievalServer = serverInfo.getLegacyRetrievalServer();
Review comment:
Yes, nice catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-624766381
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-626079616
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-620913082
R: @ihji
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on a change in pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
ihji commented on a change in pull request #11521:
URL: https://github.com/apache/beam/pull/11521#discussion_r421047427
##########
File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/GrpcFnServer.java
##########
@@ -39,6 +43,59 @@
return new GrpcFnServer<>(server, service, apiServiceDescriptor.build());
}
+ /**
+ * Create a {@link GrpcFnServer}s for the provided {@link FnService}s running on an arbitrary
+ * port.
+ */
+ public static List<GrpcFnServer<? extends FnService>> allocatePortAndCreateFor(
+ List<? extends FnService> services, ServerFactory factory) throws IOException {
+ ApiServiceDescriptor.Builder apiServiceDescriptor = ApiServiceDescriptor.newBuilder();
+ Server server =
+ factory.allocateAddressAndCreate(
+ Collections.unmodifiableList(services), apiServiceDescriptor);
+ AtomicInteger countdown = new AtomicInteger(services.size());
+ return Lists.transform(
+ services,
+ service ->
+ new SharedGrpcFnServer<>(server, service, apiServiceDescriptor.build(), countdown));
+ }
+
+ /**
+ * Create a {@link GrpcFnServer}s for the provided {@link FnService}s running on a specified port.
Review comment:
`Create {@link GrpcFnServer}s`?
##########
File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/GrpcFnServer.java
##########
@@ -39,6 +43,59 @@
return new GrpcFnServer<>(server, service, apiServiceDescriptor.build());
}
+ /**
+ * Create a {@link GrpcFnServer}s for the provided {@link FnService}s running on an arbitrary
Review comment:
`Create {@link GrpcFnServer}s`?
##########
File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -613,7 +620,7 @@ public synchronized void close() {
// These will be closed in the reverse creation order:
try (AutoCloseable envCloser = environment;
AutoCloseable provisioningServer = serverInfo.getProvisioningServer();
- AutoCloseable retrievalServer = serverInfo.getRetrievalServer();
+ AutoCloseable retrievalServer = serverInfo.getLegacyRetrievalServer();
Review comment:
Shouldn't we also close `retrievalServer`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-632241122
[BEAM-9971](https://issues.apache.org/jira/browse/BEAM-9971) was filed to track
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-632237798
@robertwb I think this broke Java PVR Spark Batch. First failure is here: https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/2887/ Not sure if there is a jira already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-625979601
Run XVR_Flink PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-623600647
Ping @ihji
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org