You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/09/16 17:22:12 UTC

Re: svn commit: propchange - r33085 - svn:log

Thanks, Arfrever.  I should have paid a bit more attention to the log.

Eirik, see Arfrever's edits below.

-Karl

arfrever@tigris.org writes:
> Author: arfrever
> Revision: 33085
> Property Name: svn:log
> Action: modified
>
> Property diff:
> --- old property value
> +++ new property value
> @@ -27,12 +27,13 @@ Patch by: Eirik Bjørsnøs <eirbjo@gmail
>    (svn_cl__log): Create an empty revprops array if no_revprops is set.
>  
>  * subversion/svn/main.c
> -  (svn_cl__longopt_t) Add opt_with_no_revprops
> -  (svn_cl__options) Add "with-no-revprops" option
> -  (main) Check for opt_with_no_revprops being set
> +  (svn_cl__longopt_t): Add opt_with_no_revprops.
> +  (svn_cl__options): Add "with-no-revprops" option.
> +  (svn_cl__cmd_table."log"): Add opt_with_no_revprops.
> +  (main) Check for opt_with_no_revprops being set.
>  
>  * notes/webdav-protocol
> -  (log-report) Add "no-revprops" option
> +  (log-report): Add "no-revprops" option.
>  
>  * subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout: 
>    Adjust for above.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: svn commit: propchange - r33085 - svn:log

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Arfrever Frehtes Taifersar Arahesis wrote on Tue, 16 Sep 2008 at 22:15 +0200:
> 2008-09-16 21:42:24 Eirik Bjørsnøs napisał(a):
> > (And the log message of my next patch will have a proper use of
> > colons. I promise :-)
> 
> Your original log message was mainly lacking:
> (svn_cl__cmd_table."log"): Add opt_with_no_revprops.
> 

I think we can forgive Eirik for this :)

Re: svn commit: propchange - r33085 - svn:log

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-16 21:42:24 Eirik Bjørsnøs napisał(a):
> (And the log message of my next patch will have a proper use of
> colons. I promise :-)

Your original log message was mainly lacking:
(svn_cl__cmd_table."log"): Add opt_with_no_revprops.

-- 
Arfrever Frehtes Taifersar Arahesis

Re: svn commit: propchange - r33085 - svn:log

Posted by Eirik Bjørsnøs <ei...@gmail.com>.
On Tue, Sep 16, 2008 at 7:22 PM, Karl Fogel <kf...@red-bean.com> wrote:
> Thanks, Arfrever.  I should have paid a bit more attention to the log.
>
> Eirik, see Arfrever's edits below.

Thanks to Karl for applying the patch and to the people who helped
review and improve it. No wonder Subversion is so great with this kind
of people backing it.

My next goal is to add a way to limit recursion depth of svn log -g.
More on that later, I just need to get this cold out of my system
first.

(And the log message of my next patch will have a proper use of
colons. I promise :-)

Eirik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org